Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 2092083002: Revert of Use instance type in Object::IsErrorObject(). (Closed)

Created:
4 years, 6 months ago by Michael Achenbach
Modified:
4 years, 6 months ago
CC:
jochen (gone - plz use gerrit), esprehn, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@RefactorToString
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Use instance type in Object::IsErrorObject(). (patchset #9 id:160001 of https://codereview.chromium.org/2090333002/ ) Reason for revert: [Sheriff] Breaks layout tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/7700 Please rebase upstream first if intended. Original issue's description: > Use JS_ERROR_TYPE to check for error objects. > > Replace explicit Object::IsErrorObject() with macro generated functions Object::IsJSError() and HeapObject::IsJSError(). > > BUG= > > Committed: https://crrev.com/90e4fd136387ca7271d8ea87f4fc667e4f55063b > Cr-Commit-Position: refs/heads/master@{#37244} TBR=verwaest@chromium.org,jochen@chromium.org,franzih@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/f0a03f0b9476aabf7f873ede40be41590cde445b Cr-Commit-Position: refs/heads/master@{#37250}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -130 lines) Patch
M src/api.cc View 1 chunk +16 lines, -1 line 0 comments Download
M src/isolate.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/messages.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 2 chunks +118 lines, -116 lines 0 comments Download
M src/objects.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M src/objects-inl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/wasm/test-wasm-stack.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M test/cctest/wasm/test-wasm-trap-position.cc View 3 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Created Revert of Use instance type in Object::IsErrorObject().
4 years, 6 months ago (2016-06-24 11:52:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2092083002/1
4 years, 6 months ago (2016-06-24 11:52:19 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-24 11:52:39 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-24 11:53:01 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f0a03f0b9476aabf7f873ede40be41590cde445b
Cr-Commit-Position: refs/heads/master@{#37250}

Powered by Google App Engine
This is Rietveld 408576698