src/messages.cc - Issue 2092083002: Revert of Use instance type in Object::IsErrorObject().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/messages.cc

Issue 2092083002: Revert of Use instance type in Object::IsErrorObject(). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@RefactorToString

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/messages.cc

diff --git a/src/messages.cc b/src/messages.cc

index 8b02aa316368f8be68da0bb1d40b81b4872d1f36..d5a15256b9fa0cfd75b5fda18aaa972dc15d47bf 100644

--- a/src/messages.cc

+++ b/src/messages.cc

@@ -98,7 +98,7 @@

MaybeHandle<Object> maybe_stringified;

Handle<Object> stringified;

// Make sure we don't leak uncaught internally generated Error objects.

- if (argument->IsJSError()) {

+ if (Object::IsErrorObject(isolate, argument)) {

Handle<Object> args[] = {argument};

maybe_stringified = Execution::TryCall(

isolate, isolate->no_side_effects_to_string_fun(),

« no previous file with comments | « src/isolate.cc ('k') | src/objects.h » ('j') | no next file with comments »