Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Side by Side Diff: src/objects-inl.h

Issue 2092083002: Revert of Use instance type in Object::IsErrorObject(). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@RefactorToString
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/objects.cc ('k') | test/cctest/wasm/test-wasm-stack.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Review notes: 5 // Review notes:
6 // 6 //
7 // - The use of macros in these inline functions may seem superfluous 7 // - The use of macros in these inline functions may seem superfluous
8 // but it is absolutely needed to make sure gcc generates optimal 8 // but it is absolutely needed to make sure gcc generates optimal
9 // code. gcc is not happy when attempting to inline too deep. 9 // code. gcc is not happy when attempting to inline too deep.
10 // 10 //
(...skipping 138 matching lines...) Expand 10 before | Expand all | Expand 10 after
149 TYPE_CHECKER(HeapNumber, HEAP_NUMBER_TYPE) 149 TYPE_CHECKER(HeapNumber, HEAP_NUMBER_TYPE)
150 TYPE_CHECKER(MutableHeapNumber, MUTABLE_HEAP_NUMBER_TYPE) 150 TYPE_CHECKER(MutableHeapNumber, MUTABLE_HEAP_NUMBER_TYPE)
151 TYPE_CHECKER(Symbol, SYMBOL_TYPE) 151 TYPE_CHECKER(Symbol, SYMBOL_TYPE)
152 TYPE_CHECKER(Simd128Value, SIMD128_VALUE_TYPE) 152 TYPE_CHECKER(Simd128Value, SIMD128_VALUE_TYPE)
153 153
154 #define SIMD128_TYPE_CHECKER(TYPE, Type, type, lane_count, lane_type) \ 154 #define SIMD128_TYPE_CHECKER(TYPE, Type, type, lane_count, lane_type) \
155 bool HeapObject::Is##Type() const { return map() == GetHeap()->type##_map(); } 155 bool HeapObject::Is##Type() const { return map() == GetHeap()->type##_map(); }
156 SIMD128_TYPES(SIMD128_TYPE_CHECKER) 156 SIMD128_TYPES(SIMD128_TYPE_CHECKER)
157 #undef SIMD128_TYPE_CHECKER 157 #undef SIMD128_TYPE_CHECKER
158 158
159 // TODO(cbruni): remove once all the isolate-based versions are in place.
159 #define IS_TYPE_FUNCTION_DEF(type_) \ 160 #define IS_TYPE_FUNCTION_DEF(type_) \
160 bool Object::Is##type_() const { \ 161 bool Object::Is##type_() const { \
161 return IsHeapObject() && HeapObject::cast(this)->Is##type_(); \ 162 return IsHeapObject() && HeapObject::cast(this)->Is##type_(); \
162 } 163 }
163 HEAP_OBJECT_TYPE_LIST(IS_TYPE_FUNCTION_DEF) 164 HEAP_OBJECT_TYPE_LIST(IS_TYPE_FUNCTION_DEF)
164 #undef IS_TYPE_FUNCTION_DEF 165 #undef IS_TYPE_FUNCTION_DEF
165 166
166 #define IS_TYPE_FUNCTION_DEF(Type, Value) \ 167 #define IS_TYPE_FUNCTION_DEF(Type, Value) \
167 bool Object::Is##Type(Isolate* isolate) const { \ 168 bool Object::Is##Type(Isolate* isolate) const { \
168 return this == isolate->heap()->Value(); \ 169 return this == isolate->heap()->Value(); \
(...skipping 610 matching lines...) Expand 10 before | Expand all | Expand 10 after
779 return obj->IsJSFunction(); 780 return obj->IsJSFunction();
780 } 781 }
781 782
782 783
783 TYPE_CHECKER(Code, CODE_TYPE) 784 TYPE_CHECKER(Code, CODE_TYPE)
784 TYPE_CHECKER(Oddball, ODDBALL_TYPE) 785 TYPE_CHECKER(Oddball, ODDBALL_TYPE)
785 TYPE_CHECKER(Cell, CELL_TYPE) 786 TYPE_CHECKER(Cell, CELL_TYPE)
786 TYPE_CHECKER(PropertyCell, PROPERTY_CELL_TYPE) 787 TYPE_CHECKER(PropertyCell, PROPERTY_CELL_TYPE)
787 TYPE_CHECKER(WeakCell, WEAK_CELL_TYPE) 788 TYPE_CHECKER(WeakCell, WEAK_CELL_TYPE)
788 TYPE_CHECKER(SharedFunctionInfo, SHARED_FUNCTION_INFO_TYPE) 789 TYPE_CHECKER(SharedFunctionInfo, SHARED_FUNCTION_INFO_TYPE)
789 TYPE_CHECKER(JSDate, JS_DATE_TYPE)
790 TYPE_CHECKER(JSError, JS_ERROR_TYPE)
791 TYPE_CHECKER(JSGeneratorObject, JS_GENERATOR_OBJECT_TYPE) 790 TYPE_CHECKER(JSGeneratorObject, JS_GENERATOR_OBJECT_TYPE)
792 TYPE_CHECKER(JSMessageObject, JS_MESSAGE_OBJECT_TYPE)
793 TYPE_CHECKER(JSModule, JS_MODULE_TYPE) 791 TYPE_CHECKER(JSModule, JS_MODULE_TYPE)
794 TYPE_CHECKER(JSValue, JS_VALUE_TYPE) 792 TYPE_CHECKER(JSValue, JS_VALUE_TYPE)
793 TYPE_CHECKER(JSDate, JS_DATE_TYPE)
794 TYPE_CHECKER(JSMessageObject, JS_MESSAGE_OBJECT_TYPE)
795 795
796 bool HeapObject::IsAbstractCode() const { 796 bool HeapObject::IsAbstractCode() const {
797 return IsBytecodeArray() || IsCode(); 797 return IsBytecodeArray() || IsCode();
798 } 798 }
799 799
800 bool HeapObject::IsStringWrapper() const { 800 bool HeapObject::IsStringWrapper() const {
801 return IsJSValue() && JSValue::cast(this)->value()->IsString(); 801 return IsJSValue() && JSValue::cast(this)->value()->IsString();
802 } 802 }
803 803
804 804
(...skipping 7129 matching lines...) Expand 10 before | Expand all | Expand 10 after
7934 #undef WRITE_INT64_FIELD 7934 #undef WRITE_INT64_FIELD
7935 #undef READ_BYTE_FIELD 7935 #undef READ_BYTE_FIELD
7936 #undef WRITE_BYTE_FIELD 7936 #undef WRITE_BYTE_FIELD
7937 #undef NOBARRIER_READ_BYTE_FIELD 7937 #undef NOBARRIER_READ_BYTE_FIELD
7938 #undef NOBARRIER_WRITE_BYTE_FIELD 7938 #undef NOBARRIER_WRITE_BYTE_FIELD
7939 7939
7940 } // namespace internal 7940 } // namespace internal
7941 } // namespace v8 7941 } // namespace v8
7942 7942
7943 #endif // V8_OBJECTS_INL_H_ 7943 #endif // V8_OBJECTS_INL_H_
OLDNEW
« no previous file with comments | « src/objects.cc ('k') | test/cctest/wasm/test-wasm-stack.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698