[Presubmit] check for single quotes in html properties

[Presubmit] check for single quotes in html properties

This CL will cause presubmit to warn programmers when using single
quotes in HTML property names.

BUG=622814
Committed: https://crrev.com/02602da5b8e5075e81ff0162262e0523fe4b1863
Cr-Commit-Position: refs/heads/master@{#402605}

[dschuyler, 2016-06-23 19:19:24]

dschuyler@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2016-06-23 19:28:03]

https://codereview.chromium.org/2091903002/diff/1/chrome/browser/web_dev_styl...
File chrome/browser/web_dev_style/html_checker_test.py (right):

https://codereview.chromium.org/2091903002/diff/1/chrome/browser/web_dev_styl...
chrome/browser/web_dev_style/html_checker_test.py:57: self.ShouldFailCheck(line,
self.checker.DoNotUseSingleQuotesCheck)
please add things that should succeed like

<b id="super-valid">SO VALID!</b>
<a text="i ain't got invalid quotes">i don't</a>
<span>[[i18n('blah')]]</span>

[dschuyler, 2016-06-23 20:43:10]

Patchset #2 (id:20001) has been deleted

[dschuyler, 2016-06-23 20:43:17]

Patchset #2 (id:40001) has been deleted

[dschuyler, 2016-06-23 20:44:38]

I also accounted for non-value properties
like <a hidden foo="bar"> in the checks.

https://codereview.chromium.org/2091903002/diff/1/chrome/browser/web_dev_styl...
File chrome/browser/web_dev_style/html_checker_test.py (right):

https://codereview.chromium.org/2091903002/diff/1/chrome/browser/web_dev_styl...
chrome/browser/web_dev_style/html_checker_test.py:57: self.ShouldFailCheck(line,
self.checker.DoNotUseSingleQuotesCheck)
On 2016/06/23 19:28:03, Dan Beam wrote:
> please add things that should succeed like
> 
> <b id="super-valid">SO VALID!</b>
> <a text="i ain't got invalid quotes">i don't</a>
> <span>[[i18n('blah')]]</span>

Done.

[Dan Beam, 2016-06-23 21:00:47]

https://codereview.chromium.org/2091903002/diff/60001/chrome/browser/web_dev_...
File chrome/browser/web_dev_style/html_checker.py (right):

https://codereview.chromium.org/2091903002/diff/60001/chrome/browser/web_dev_...
chrome/browser/web_dev_style/html_checker.py:49: (<\s*\S+                      
# The tag name.
HTML does not allow "< tag"

you should change <\s* to <

https://codereview.chromium.org/2091903002/diff/60001/chrome/browser/web_dev_...
chrome/browser/web_dev_style/html_checker.py:50: (?:\s+\S+\s*="[^"]*"|\s+\S+)* 
# Correctly quoted or non-value props.
i don't think attr ="blah" is valid either, can you remove \s* from this line as
well?

https://codereview.chromium.org/2091903002/diff/60001/chrome/browser/web_dev_...
chrome/browser/web_dev_style/html_checker.py:50: (?:\s+\S+\s*="[^"]*"|\s+\S+)* 
# Correctly quoted or non-value props.
what about attr$='value'?

https://codereview.chromium.org/2091903002/diff/60001/chrome/browser/web_dev_...
chrome/browser/web_dev_style/html_checker.py:54: self.input_api.re.VERBOSE)
this should probably be multi-line

https://codereview.chromium.org/2091903002/diff/60001/chrome/browser/web_dev_...
File chrome/browser/web_dev_style/html_checker_test.py (right):

https://codereview.chromium.org/2091903002/diff/60001/chrome/browser/web_dev_...
chrome/browser/web_dev_style/html_checker_test.py:64: """<a cats href='classBar'
dogs>""",
multi-line?

https://codereview.chromium.org/2091903002/diff/60001/chrome/browser/web_dev_...
chrome/browser/web_dev_style/html_checker_test.py:74: """<a cats href="classBar"
dogs>""",
multi-line?

[dschuyler, 2016-06-23 22:03:07]

https://codereview.chromium.org/2091903002/diff/60001/chrome/browser/web_dev_...
File chrome/browser/web_dev_style/html_checker.py (right):

https://codereview.chromium.org/2091903002/diff/60001/chrome/browser/web_dev_...
chrome/browser/web_dev_style/html_checker.py:49: (<\s*\S+                      
# The tag name.
On 2016/06/23 21:00:47, Dan Beam wrote:
> HTML does not allow "< tag"
> 
> you should change <\s* to <

Done.

https://codereview.chromium.org/2091903002/diff/60001/chrome/browser/web_dev_...
chrome/browser/web_dev_style/html_checker.py:50: (?:\s+\S+\s*="[^"]*"|\s+\S+)* 
# Correctly quoted or non-value props.
On 2016/06/23 21:00:47, Dan Beam wrote:
> i don't think attr ="blah" is valid either, can you remove \s* from this line
as
> well?

Done.

https://codereview.chromium.org/2091903002/diff/60001/chrome/browser/web_dev_...
chrome/browser/web_dev_style/html_checker.py:50: (?:\s+\S+\s*="[^"]*"|\s+\S+)* 
# Correctly quoted or non-value props.
On 2016/06/23 21:00:47, Dan Beam wrote:
> what about attr$='value'?

Done.

https://codereview.chromium.org/2091903002/diff/60001/chrome/browser/web_dev_...
chrome/browser/web_dev_style/html_checker.py:54: self.input_api.re.VERBOSE)
On 2016/06/23 21:00:47, Dan Beam wrote:
> this should probably be multi-line

Done.

https://codereview.chromium.org/2091903002/diff/60001/chrome/browser/web_dev_...
File chrome/browser/web_dev_style/html_checker_test.py (right):

https://codereview.chromium.org/2091903002/diff/60001/chrome/browser/web_dev_...
chrome/browser/web_dev_style/html_checker_test.py:64: """<a cats href='classBar'
dogs>""",
On 2016/06/23 21:00:47, Dan Beam wrote:
> multi-line?

Done.

https://codereview.chromium.org/2091903002/diff/60001/chrome/browser/web_dev_...
chrome/browser/web_dev_style/html_checker_test.py:74: """<a cats href="classBar"
dogs>""",
On 2016/06/23 21:00:47, Dan Beam wrote:
> multi-line?

Done.

[Dan Beam, 2016-06-25 00:49:03]

lgtm w/nits

https://codereview.chromium.org/2091903002/diff/80001/chrome/browser/web_dev_...
File chrome/browser/web_dev_style/html_checker.py (right):

https://codereview.chromium.org/2091903002/diff/80001/chrome/browser/web_dev_...
chrome/browser/web_dev_style/html_checker.py:52: [^>]*>)                       
# To the end of the tag.
why is the match around the whole tag?  why not just around the single quotes or
singly-quoted part?

https://codereview.chromium.org/2091903002/diff/80001/chrome/browser/web_dev_...
File chrome/browser/web_dev_style/html_checker_test.py (right):

https://codereview.chromium.org/2091903002/diff/80001/chrome/browser/web_dev_...
chrome/browser/web_dev_style/html_checker_test.py:65: """<a cats\n
href='classBar'\n dogs>""",
"""<a cats href='classBat\nclassBaz' dogs>"""

https://codereview.chromium.org/2091903002/diff/80001/chrome/browser/web_dev_...
File chrome/browser/web_dev_style/test_util.py (right):

https://codereview.chromium.org/2091903002/diff/80001/chrome/browser/web_dev_...
chrome/browser/web_dev_style/test_util.py:9: # TODO(dschuyler): delve into
multi-line errors further.
what's the issue here exactly?

[dschuyler, 2016-06-28 19:03:43]

Patchset #4 (id:100001) has been deleted

[dschuyler, 2016-06-28 19:04:18]

https://codereview.chromium.org/2091903002/diff/80001/chrome/browser/web_dev_...
File chrome/browser/web_dev_style/html_checker.py (right):

https://codereview.chromium.org/2091903002/diff/80001/chrome/browser/web_dev_...
chrome/browser/web_dev_style/html_checker.py:52: [^>]*>)                       
# To the end of the tag.
On 2016/06/25 00:49:03, Dan Beam wrote:
> why is the match around the whole tag?  why not just around the single quotes
or
> singly-quoted part?

I'd thought that the context around the error would be helpful.
Though I can also see it being helpful to narrow down error to
better see what the issue is. It now has the property name and
value.

Done.

https://codereview.chromium.org/2091903002/diff/80001/chrome/browser/web_dev_...
File chrome/browser/web_dev_style/html_checker_test.py (right):

https://codereview.chromium.org/2091903002/diff/80001/chrome/browser/web_dev_...
chrome/browser/web_dev_style/html_checker_test.py:65: """<a cats\n
href='classBar'\n dogs>""",
On 2016/06/25 00:49:03, Dan Beam wrote:
> """<a cats href='classBat\nclassBaz' dogs>"""

Done.

https://codereview.chromium.org/2091903002/diff/80001/chrome/browser/web_dev_...
File chrome/browser/web_dev_style/test_util.py (right):

https://codereview.chromium.org/2091903002/diff/80001/chrome/browser/web_dev_...
chrome/browser/web_dev_style/test_util.py:9: # TODO(dschuyler): delve into
multi-line errors further.
On 2016/06/25 00:49:03, Dan Beam wrote:
> what's the issue here exactly?

Changed comment to better explain.

Done.

[dschuyler, 2016-06-28 23:05:43]

The CQ bit was checked by dschuyler@chromium.org

[dschuyler, 2016-06-28 23:05:43]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2091903002/#ps120001
(title: "review changes")

[commit-bot: I haz the power, 2016-06-28 23:08:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 23:56:29]

Committed patchset #4 (id:120001)

[commit-bot: I haz the power, 2016-06-28 23:57:55]

Description was changed from

==========
[Presubmit] check for single quotes in html properties

This CL will cause presubmit to warn programmers when using single
quotes in HTML property names.

BUG=622814
==========

to

==========
[Presubmit] check for single quotes in html properties

This CL will cause presubmit to warn programmers when using single
quotes in HTML property names.

BUG=622814

Committed: https://crrev.com/02602da5b8e5075e81ff0162262e0523fe4b1863
Cr-Commit-Position: refs/heads/master@{#402605}
==========

[commit-bot: I haz the power, 2016-06-28 23:57:56]

Patchset 4 (id:??) landed as
https://crrev.com/02602da5b8e5075e81ff0162262e0523fe4b1863
Cr-Commit-Position: refs/heads/master@{#402605}