[Presubmit] check for single quotes in html properties

chrome/browser/web_dev_style/html_checker_test.py

 #!/usr/bin/env python
 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import html_checker
 from os import path as os_path
 import re
 from sys import path as sys_path
 import test_util
@@ skipping 29 matching lines @@
   def testClassesUseDashFormCheckFails(self):
     lines = [
       ' <a class="Foo-bar" href="classBar"> ',
       '<b class="foo-Bar"> ',
       '<i class="foo_bar" >',
       ' <hr class="fooBar"> ',
     ]
     for line in lines:
       self.ShouldFailCheck(line, self.checker.ClassesUseDashFormCheck)
 
+  def testSingleQuoteCheckFails(self):
+    lines = [
+      """ <a href='classBar'> """,
+      """<a foo="bar" href='classBar'>""",
+      """<a foo="bar" less="more" href='classBar' kittens="cats">""",
+    ]
+    for line in lines:
+      self.ShouldFailCheck(line, self.checker.DoNotUseSingleQuotesCheck)

[Dan Beam, 2016/06/23 19:28:03]

please add things that should succeed like

<b id="super-valid">SO VALID!</b>
<a text="i ain't got invalid quotes">i don't</a>
<span>[[i18n('blah')]]</span>

[dschuyler, 2016/06/23 20:44:37]

Done.

+
   def testClassesUseDashFormCheckPasses(self):
     lines = [
       ' class="abc" ',
       'class="foo-bar"',
       '<div class="foo-bar" id="classBar"',
     ]
     for line in lines:
       self.ShouldPassCheck(line, self.checker.ClassesUseDashFormCheck)
 
   def testDoNotCloseSingleTagsCheckFails(self):
@@ skipping 101 matching lines @@
       ' my-for="abc" ',
       ' myfor="abc" ',
       " <for",
     ]
     for line in lines:
       self.ShouldPassCheck(line, self.checker.LabelCheck)
 
 
 if __name__ == '__main__':
   unittest.main()