chrome/browser/web_dev_style/test_util.py - Issue 2091903002: [Presubmit] check for single quotes in html properties

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/web_dev_style/test_util.py

Issue 2091903002: [Presubmit] check for single quotes in html properties (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: multi-line Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright 2015 The Chromium Authors. All rights reserved.	1 # Copyright 2015 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5	5

6 def GetHighlight(line, error):	6 def GetHighlight(line, error):

7 """Returns the substring of \|line\| that is highlighted in \|error\|."""	7 """Returns the substring of \|line\| that is highlighted in \|error\|."""

8 error_lines = error.split('\n')	8 error_lines = error.split('\n')

	9 # TODO(dschuyler): delve into multi-line errors further.
	Dan Beam 2016/06/25 00:49:03 what's the issue here exactly? what's the issue here exactly? dschuyler 2016/06/28 19:04:18 Changed comment to better explain. Done. Show quoted text On 2016/06/25 00:49:03, Dan Beam wrote: > what's the issue here exactly? Changed comment to better explain. Done.
	10 if line not in error_lines:

	11 return line

9 highlight = error_lines[error_lines.index(line) + 1]	12 highlight = error_lines[error_lines.index(line) + 1]

10 return ''.join(ch1 for (ch1, ch2) in zip(line, highlight) if ch2 == '^')	13 return ''.join(ch1 for (ch1, ch2) in zip(line, highlight) if ch2 == '^')

OLD	NEW

« chrome/browser/web_dev_style/html_checker_test.py ('K') | « chrome/browser/web_dev_style/html_checker_test.py ('k') | no next file » | no next file with comments »