src/runtime/runtime-debug.cc - Issue 2091243002: Use the instance type to determine if an object is a promise.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-debug.cc

Issue 2091243002: Use the instance type to determine if an object is a promise. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@SimplifyIsError

Patch Set: Rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/runtime/runtime-debug.cc

diff --git a/src/runtime/runtime-debug.cc b/src/runtime/runtime-debug.cc

index dcdffb748051a55f51d983823b21f8af7c34a9fc..b3be8f7671136b3ec8a9ac7235e83008021614fe 100644

--- a/src/runtime/runtime-debug.cc

+++ b/src/runtime/runtime-debug.cc

@@ -243,7 +243,7 @@ MaybeHandle<JSArray> Runtime::GetInternalProperties(Isolate* isolate,

result->set(4, *receiver);

result->set(5, generator->receiver());

return factory->NewJSArrayWithElements(result);

- } else if (Object::IsPromise(object)) {

+ } else if (object->IsJSPromise()) {

Handle<JSObject> promise = Handle<JSObject>::cast(object);

Handle<Object> status_obj =

« no previous file with comments | « src/objects-inl.h ('k') | no next file » | no next file with comments »