Reland: WTF: Simplify RefPtr::operator bool.

Reland: WTF: Simplify RefPtr::operator bool.

The problematic case in String::find on ARM should now be gone, and so this
should be both simpler and equally fast.

Comparing to nullptr is used to coerce to boolean to work around bug 621177
(even though this is usually not the preferred way to do this in Blink).

BUG=607208, 621177
Committed: https://crrev.com/4db41c4c92314447a07a2255d97c344547f97ce7
Cr-Commit-Position: refs/heads/master@{#401897}

[jbroman, 2016-06-23 15:09:33]

jbroman@chromium.org changed reviewers:
+ thakis@chromium.org

[jbroman, 2016-06-23 15:09:33]

Here we go again. There was an issue on the GYP (but not GN, like the trybots)
Windows bots, wherein we suppress warnings about ptr-to-bool conversion in
Blink, but not in //content/renderer. Unfortunately, there is currently a file
in content which (transitively) includes wtf/RefPtr.h, so there is a compile
failure if that file doesn't pass Chromium's more stringent warning settings.

The discussion on bug 621177 is still ongoing, but this works around the issue
for now. (I've verified this with a local Windows build, since the trybots don't
detect this.)

[Nico, 2016-06-23 16:02:06]

lgtm

:-( :-( on content including RefPtr, :-( on trybots being gn-only

https://codereview.chromium.org/2090973002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/wtf/PassRefPtr.h (right):

https://codereview.chromium.org/2090973002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/wtf/PassRefPtr.h:85: explicit operator bool() const {
return !!m_ptr; }
no !! pls

[jbroman, 2016-06-23 16:05:44]

https://codereview.chromium.org/2090973002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/wtf/PassRefPtr.h (right):

https://codereview.chromium.org/2090973002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/wtf/PassRefPtr.h:85: explicit operator bool() const {
return !!m_ptr; }
On 2016/06/23 at 16:02:06, Nico wrote:
> no !! pls

Windows warns (with our flags, errors) about "return m_ptr;"; that's the reason
the previous CL was reverted.
Which pattern would you prefer? I could do "return m_ptr != nullptr;", if that's
better, but this seemed reasonably natural, comparing to the operator!
implementation above.

[Nico, 2016-06-23 16:07:15]

!= nullptr

[jbroman, 2016-06-23 17:13:47]

Description was changed from

==========
Reland: WTF: Simplify RefPtr::operator bool.

The problematic case in String::find on ARM should now be gone, and so this
should be both simpler and equally fast.

!! is used to coerce to boolean to work around bug 621177.

BUG=607208,621177
==========

to

==========
Reland: WTF: Simplify RefPtr::operator bool.

The problematic case in String::find on ARM should now be gone, and so this
should be both simpler and equally fast.

Comparing to nullptr is used to coerce to boolean to work around bug 621177.
(Even though this is usually not the preferred way to do this in Blink.)

BUG=607208,621177
==========

[jbroman, 2016-06-23 17:13:56]

Description was changed from

==========
Reland: WTF: Simplify RefPtr::operator bool.

The problematic case in String::find on ARM should now be gone, and so this
should be both simpler and equally fast.

Comparing to nullptr is used to coerce to boolean to work around bug 621177.
(Even though this is usually not the preferred way to do this in Blink.)

BUG=607208,621177
==========

to

==========
Reland: WTF: Simplify RefPtr::operator bool.

The problematic case in String::find on ARM should now be gone, and so this
should be both simpler and equally fast.

Comparing to nullptr is used to coerce to boolean to work around bug 621177
(even though this is usually not the preferred way to do this in Blink).

BUG=607208,621177
==========

[jbroman, 2016-06-23 17:14:19]

Done, though it requires bypassing check-webkit-style, which doesn't like
comparison to true, false and null.

[jbroman, 2016-06-24 14:59:29]

The CQ bit was checked by jbroman@chromium.org

[jbroman, 2016-06-24 14:59:29]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2090973002/#ps40001
(title: "!= nullptr")

[commit-bot: I haz the power, 2016-06-24 14:59:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-24 17:41:05]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-24 17:44:10]

Description was changed from

==========
Reland: WTF: Simplify RefPtr::operator bool.

The problematic case in String::find on ARM should now be gone, and so this
should be both simpler and equally fast.

Comparing to nullptr is used to coerce to boolean to work around bug 621177
(even though this is usually not the preferred way to do this in Blink).

BUG=607208,621177
==========

to

==========
Reland: WTF: Simplify RefPtr::operator bool.

The problematic case in String::find on ARM should now be gone, and so this
should be both simpler and equally fast.

Comparing to nullptr is used to coerce to boolean to work around bug 621177
(even though this is usually not the preferred way to do this in Blink).

BUG=607208,621177

Committed: https://crrev.com/4db41c4c92314447a07a2255d97c344547f97ce7
Cr-Commit-Position: refs/heads/master@{#401897}
==========

[commit-bot: I haz the power, 2016-06-24 17:44:12]

Patchset 3 (id:??) landed as
https://crrev.com/4db41c4c92314447a07a2255d97c344547f97ce7
Cr-Commit-Position: refs/heads/master@{#401897}