Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Unified Diff: third_party/WebKit/Source/wtf/PassRefPtr.h

Issue 2090973002: Reland: WTF: Simplify RefPtr::operator bool. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: != nullptr Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/wtf/RefPtr.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/wtf/PassRefPtr.h
diff --git a/third_party/WebKit/Source/wtf/PassRefPtr.h b/third_party/WebKit/Source/wtf/PassRefPtr.h
index 48538cd788a66d22bbbe934ef426f31801288f61..53aad9276218dda2c6fe0a8f014312108d0dd434 100644
--- a/third_party/WebKit/Source/wtf/PassRefPtr.h
+++ b/third_party/WebKit/Source/wtf/PassRefPtr.h
@@ -82,10 +82,7 @@ public:
T* operator->() const { return m_ptr; }
bool operator!() const { return !m_ptr; }
-
- // TODO(jbroman): Simplifying this in the obvious way causes a massive
- // regression in a perf test on ARM. http://crbug.com/607208
- explicit operator bool() const { return m_ptr ? &PassRefPtr::m_ptr : 0; }
+ explicit operator bool() const { return m_ptr != nullptr; }
friend PassRefPtr adoptRef<T>(T*);
« no previous file with comments | « no previous file | third_party/WebKit/Source/wtf/RefPtr.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698