Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: third_party/WebKit/Source/wtf/RefPtr.h

Issue 2090973002: Reland: WTF: Simplify RefPtr::operator bool. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: != nullptr Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/wtf/PassRefPtr.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/wtf/RefPtr.h
diff --git a/third_party/WebKit/Source/wtf/RefPtr.h b/third_party/WebKit/Source/wtf/RefPtr.h
index eab641a66509aeca93b469c0f35c46e30c7ac44b..0097b914fe56229596f906da298c79dc80788251 100644
--- a/third_party/WebKit/Source/wtf/RefPtr.h
+++ b/third_party/WebKit/Source/wtf/RefPtr.h
@@ -70,10 +70,7 @@ public:
ALWAYS_INLINE T* operator->() const { return m_ptr; }
bool operator!() const { return !m_ptr; }
-
- // TODO(jbroman): Simplifying this in the obvious way causes a massive
- // regression in a perf test on ARM. http://crbug.com/607208
- explicit operator bool() const { return m_ptr ? &RefPtr::m_ptr : 0; }
+ explicit operator bool() const { return m_ptr != nullptr; }
RefPtr& operator=(RefPtr o) { swap(o); return *this; }
RefPtr& operator=(std::nullptr_t) { clear(); return *this; }
« no previous file with comments | « third_party/WebKit/Source/wtf/PassRefPtr.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698