Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(885)

Issue 2090063002: Remove calls to deprecated MessageLoop methods in extensions. (Closed)

Created:
4 years, 6 months ago by fdoray
Modified:
4 years, 6 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove calls to deprecated MessageLoop methods in extensions. This CL makes the following replacements in extensions: Before After ---------------------------------------------------------- x.PostTask() x.task_runner()->PostTask() PostDelayedTask() PostDelayedTask() ReleaseSoon() ReleaseSoon() DeleteSoon() DeleteSoon() x->PostTask() y->task_runner()->PostTask() PostDelayedTask() PostDelayedTask() ReleaseSoon() ReleaseSoon() DeleteSoon() DeleteSoon() x.Run() RunLoop().Run() x.RunUntilIdle() RunLoop().RunUntilIdle() x->Run() RunLoop().Run() x->RunUntilIdle() RunLoop().RunUntilIdle() If |y| isn't MessageLoopForUI::current() or MessageLoopForIO::current() y.message_loop()->task_runner() y.task_runner() y->message_loop()->task_runner() y->task_runner() ---------------------------------------------------------- |x| is a base::MessageLoop(ForUI|ForIO) or a pointer to a base::MessageLoop(ForUI|ForIO). |y| is a base::Thread or a pointer to a base::Thread. This CL was generated using the MessageLoopDeprecatedMethods clang-tidy fix available on the associated bug. Only files that compile on Mac are affected. Follow-up CLs will make these replacements for other platforms. This CL doesn't change code behavior. BUG=616447 R=reillyg@chromium.org Committed: https://crrev.com/2edf4dd2c1b1d4f217025e1cbb50479c32e7a974 Cr-Commit-Position: refs/heads/master@{#401317}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -28 lines) Patch
M extensions/browser/api/alarms/alarms_api_unittest.cc View 11 chunks +12 lines, -11 lines 0 comments Download
M extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M extensions/browser/api/storage/storage_frontend_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/extension_icon_image_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M extensions/browser/file_reader.cc View 2 chunks +3 lines, -1 line 0 comments Download
M extensions/browser/file_reader_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M extensions/browser/image_loader_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M extensions/browser/quota_service_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M extensions/browser/value_store/value_store_frontend_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M extensions/renderer/gc_callback_unittest.cc View 5 chunks +5 lines, -4 lines 0 comments Download
M extensions/renderer/script_context_set_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
fdoray
Can you review this CL? Thanks.
4 years, 6 months ago (2016-06-22 15:40:42 UTC) #1
Reilly Grant (use Gerrit)
lgtm
4 years, 6 months ago (2016-06-22 16:58:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2090063002/1
4 years, 6 months ago (2016-06-22 17:03:11 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-22 17:09:19 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 17:11:08 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2edf4dd2c1b1d4f217025e1cbb50479c32e7a974
Cr-Commit-Position: refs/heads/master@{#401317}

Powered by Google App Engine
This is Rietveld 408576698