extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc - Issue 2090063002: Remove calls to deprecated MessageLoop methods in extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc

Issue 2090063002: Remove calls to deprecated MessageLoop methods in extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/alarms/alarms_api_unittest.cc ('k') | extensions/browser/api/storage/storage_frontend_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc

diff --git a/extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc b/extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc

index 30a70bf82674d22118de5a93ccdc89455e667c87..905bb2a17f8ab5092af8a16b87e79a5ebebd96b0 100644

--- a/extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc

+++ b/extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc

@@ -12,6 +12,7 @@

#include "base/files/file_path.h"

#include "base/macros.h"

#include "base/message_loop/message_loop.h"

+#include "base/run_loop.h"

#include "base/values.h"

#include "content/public/browser/resource_request_info.h"

#include "extensions/browser/api/declarative_webrequest/webrequest_condition.h"

@@ -151,7 +152,7 @@ TEST(WebRequestConditionAttributeTest, ContentType) {

std::unique_ptr<net::URLRequest> url_request(context.CreateRequest(

test_server.GetURL("/headers.html"), net::DEFAULT_PRIORITY, &delegate));

url_request->Start();

- base::MessageLoop::current()->Run();

+ base::RunLoop().Run();

base::ListValue content_types;

content_types.AppendString("text/plain");

@@ -455,7 +456,7 @@ TEST(WebRequestConditionAttributeTest, RequestHeaders) {

url_request->SetExtraRequestHeaderByName(

"Custom-header", "custom/value", true /* overwrite */);

url_request->Start();

- base::MessageLoop::current()->Run();

+ base::RunLoop().Run();

std::vector<std::vector<const std::string*> > tests;

bool result = false;

@@ -540,7 +541,7 @@ TEST(WebRequestConditionAttributeTest, ResponseHeaders) {

std::unique_ptr<net::URLRequest> url_request(context.CreateRequest(

test_server.GetURL("/headers.html"), net::DEFAULT_PRIORITY, &delegate));

url_request->Start();

- base::MessageLoop::current()->Run();

+ base::RunLoop().Run();

// In all the tests below we assume that the server includes the headers

// Custom-Header: custom/value