Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: extensions/renderer/gc_callback_unittest.cc

Issue 2090063002: Remove calls to deprecated MessageLoop methods in extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/gc_callback_unittest.cc
diff --git a/extensions/renderer/gc_callback_unittest.cc b/extensions/renderer/gc_callback_unittest.cc
index 06bfb81171a3e3f72b71d2ac4b50ada6c2511a97..44bdb3375416ea4889aee23a6590a7cd4441694d 100644
--- a/extensions/renderer/gc_callback_unittest.cc
+++ b/extensions/renderer/gc_callback_unittest.cc
@@ -6,6 +6,7 @@
#include "base/macros.h"
#include "base/memory/weak_ptr.h"
#include "base/message_loop/message_loop.h"
+#include "base/run_loop.h"
#include "extensions/common/extension.h"
#include "extensions/common/extension_set.h"
#include "extensions/common/features/feature.h"
@@ -106,7 +107,7 @@ TEST_F(GCCallbackTest, GCBeforeContextInvalidated) {
// Trigger a GC. Only the callback should be invoked.
RequestGarbageCollection();
- message_loop().RunUntilIdle();
+ base::RunLoop().RunUntilIdle();
EXPECT_TRUE(callback_invoked);
EXPECT_FALSE(fallback_invoked);
@@ -114,7 +115,7 @@ TEST_F(GCCallbackTest, GCBeforeContextInvalidated) {
// Invalidate the context. The fallback should not be invoked because the
// callback was already invoked.
script_context_set().Remove(script_context);
- message_loop().RunUntilIdle();
+ base::RunLoop().RunUntilIdle();
EXPECT_FALSE(fallback_invoked);
}
@@ -144,7 +145,7 @@ TEST_F(GCCallbackTest, ContextInvalidatedBeforeGC) {
// Invalidate the context. Only the fallback should be invoked.
script_context_set().Remove(script_context);
- message_loop().RunUntilIdle();
+ base::RunLoop().RunUntilIdle();
EXPECT_FALSE(callback_invoked);
EXPECT_TRUE(fallback_invoked);
@@ -152,7 +153,7 @@ TEST_F(GCCallbackTest, ContextInvalidatedBeforeGC) {
// Trigger a GC. The callback should not be invoked because the fallback was
// already invoked.
RequestGarbageCollection();
- message_loop().RunUntilIdle();
+ base::RunLoop().RunUntilIdle();
EXPECT_FALSE(callback_invoked);
}
« no previous file with comments | « extensions/browser/value_store/value_store_frontend_unittest.cc ('k') | extensions/renderer/script_context_set_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698