Split enable_alternative_service_with_different_host flag.

Split enable_alternative_service_with_different_host flag.

Split enable_alternative_service_with_different_host flag into separate HTTP/2
and QUIC flags.  Also remove
* unnecessary assigments from tests,
* test in DataReductionProxyIODataTest.TestConstruction: it is moot because both
  HTTP/2 and QUIC are disabled anyway,
* assignment from UrlRequestContextBuilder, see justification below.

HTTP/2 AltSvc for alternative service host different from that of the origin is
currently broken, see linked bug.  Therefore
enable_http2_alternative_service_with_different_host is disabled in production
and for all tests for the time being.  It will be used in writing tests when
fixing the linked bug.  Also, this flag will make it easier to remove flag
enable_alternative_services_for_insecure_origins from tests.  Also, no clients
of the network stack should be able to flip this flag directly because of the
linked bug, that is why it is not added to UrlRequestContextBuilder.

On the other hand, QUIC AltSvc works correctly, thus
enable_quic_alternative_service_with_different_host is enabled by default both
in production and tests.  It is only there temporarily as a kill switch in case
something goes wrong, and will eventually be removed.  Therefore no clients of
the network stack should have the need to flip this flag directly.  Furthermore,
this flag is moot if QUIC is disabled.  That is why it is not added to
UrlRequestContextBuilder.

BUG=615413
Committed: https://crrev.com/a8681534b79e6352c68fe106e2433fa92d0f5671
Cr-Commit-Position: refs/heads/master@{#402154}

[Bence, 2016-06-22 17:54:13]

bnc@chromium.org changed reviewers:
+ rch@chromium.org

[Bence, 2016-06-22 17:54:13]

Ryan: PTAL.  Thank you.

[Ryan Hamilton, 2016-06-22 18:00:45]

lgtm

https://codereview.chromium.org/2089243002/diff/1/components/data_reduction_p...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data_unittest.cc
(left):

https://codereview.chromium.org/2089243002/diff/1/components/data_reduction_p...
components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data_unittest.cc:114:
EXPECT_TRUE(http_params->enable_alternative_service_with_different_host);
should this check the quic param?

[Bence, 2016-06-23 11:11:44]

bnc@chromium.org changed reviewers:
+ bengr@chromium.org, sergeyu@chromium.org

[Bence, 2016-06-23 11:11:45]

bengr: PTAL components/data_reduction_proxy/
Sergey: PTAL at jingle/glue/
Ryan: Thank you.

https://codereview.chromium.org/2089243002/diff/1/components/data_reduction_p...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data_unittest.cc
(left):

https://codereview.chromium.org/2089243002/diff/1/components/data_reduction_p...
components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data_unittest.cc:114:
EXPECT_TRUE(http_params->enable_alternative_service_with_different_host);
On 2016/06/22 18:00:45, Ryan Hamilton wrote:
> should this check the quic param?

I do not believe so, since both HTTP/2 and QUIC are disabled, so both flags are
moot, and removing them later would cause unnecessary churn here.

[Sergey Ulanov, 2016-06-23 21:32:35]

jingle lgtm

[bengr, 2016-06-27 01:26:55]

components/data_reduction_proxy* lgtm

[Bence, 2016-06-27 11:22:14]

The CQ bit was checked by bnc@chromium.org

[commit-bot: I haz the power, 2016-06-27 11:22:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 12:28:05]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-27 12:29:37]

Description was changed from

==========
Split enable_alternative_service_with_different_host flag.

Split enable_alternative_service_with_different_host flag into separate HTTP/2
and QUIC flags.  Also remove
* unnecessary assigments from tests,
* test in DataReductionProxyIODataTest.TestConstruction: it is moot because both
  HTTP/2 and QUIC are disabled anyway,
* assignment from UrlRequestContextBuilder, see justification below.

HTTP/2 AltSvc for alternative service host different from that of the origin is
currently broken, see linked bug.  Therefore
enable_http2_alternative_service_with_different_host is disabled in production
and for all tests for the time being.  It will be used in writing tests when
fixing the linked bug.  Also, this flag will make it easier to remove flag
enable_alternative_services_for_insecure_origins from tests.  Also, no clients
of the network stack should be able to flip this flag directly because of the
linked bug, that is why it is not added to UrlRequestContextBuilder.

On the other hand, QUIC AltSvc works correctly, thus
enable_quic_alternative_service_with_different_host is enabled by default both
in production and tests.  It is only there temporarily as a kill switch in case
something goes wrong, and will eventually be removed.  Therefore no clients of
the network stack should have the need to flip this flag directly.  Furthermore,
this flag is moot if QUIC is disabled.  That is why it is not added to
UrlRequestContextBuilder.

BUG=615413
==========

to

==========
Split enable_alternative_service_with_different_host flag.

Split enable_alternative_service_with_different_host flag into separate HTTP/2
and QUIC flags.  Also remove
* unnecessary assigments from tests,
* test in DataReductionProxyIODataTest.TestConstruction: it is moot because both
  HTTP/2 and QUIC are disabled anyway,
* assignment from UrlRequestContextBuilder, see justification below.

HTTP/2 AltSvc for alternative service host different from that of the origin is
currently broken, see linked bug.  Therefore
enable_http2_alternative_service_with_different_host is disabled in production
and for all tests for the time being.  It will be used in writing tests when
fixing the linked bug.  Also, this flag will make it easier to remove flag
enable_alternative_services_for_insecure_origins from tests.  Also, no clients
of the network stack should be able to flip this flag directly because of the
linked bug, that is why it is not added to UrlRequestContextBuilder.

On the other hand, QUIC AltSvc works correctly, thus
enable_quic_alternative_service_with_different_host is enabled by default both
in production and tests.  It is only there temporarily as a kill switch in case
something goes wrong, and will eventually be removed.  Therefore no clients of
the network stack should have the need to flip this flag directly.  Furthermore,
this flag is moot if QUIC is disabled.  That is why it is not added to
UrlRequestContextBuilder.

BUG=615413

Committed: https://crrev.com/a8681534b79e6352c68fe106e2433fa92d0f5671
Cr-Commit-Position: refs/heads/master@{#402154}
==========

[commit-bot: I haz the power, 2016-06-27 12:29:38]

Patchset 1 (id:??) landed as
https://crrev.com/a8681534b79e6352c68fe106e2433fa92d0f5671
Cr-Commit-Position: refs/heads/master@{#402154}