Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2153)

Unified Diff: net/quic/quic_network_transaction_unittest.cc

Issue 2089243002: Split enable_alternative_service_with_different_host flag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/quic_network_transaction_unittest.cc
diff --git a/net/quic/quic_network_transaction_unittest.cc b/net/quic/quic_network_transaction_unittest.cc
index e4dacf4d78cfaf96d82162eec69c06630eb7c770..f32deb3a54954f885aa56c5e9c72c9eb7ca0845c 100644
--- a/net/quic/quic_network_transaction_unittest.cc
+++ b/net/quic/quic_network_transaction_unittest.cc
@@ -267,7 +267,6 @@ class QuicNetworkTransactionTest
request_.load_flags = 0;
clock_->AdvanceTime(QuicTime::Delta::FromMilliseconds(20));
- params_.enable_alternative_service_with_different_host = true;
params_.enable_alternative_service_for_insecure_origins = true;
scoped_refptr<X509Certificate> cert(
@@ -713,7 +712,6 @@ TEST_P(QuicNetworkTransactionTest, ForceQuic) {
// the alternate-protocol job will "win".
AddHangingNonAlternateProtocolSocketData();
- params_.enable_alternative_service_with_different_host = false;
CreateSession();
EXPECT_FALSE(
@@ -786,7 +784,6 @@ TEST_P(QuicNetworkTransactionTest, QuicProxy) {
// no attempt will be made to speak to the proxy over TCP.
request_.url = GURL("http://mail.example.org/");
- params_.enable_alternative_service_with_different_host = false;
CreateSession();
SendRequestAndExpectQuicResponseFromProxyOnPort("hello!", 70);
@@ -841,7 +838,6 @@ TEST_P(QuicNetworkTransactionTest, QuicProxyWithCert) {
}
TEST_P(QuicNetworkTransactionTest, AlternativeServicesDifferentHost) {
- params_.enable_alternative_service_with_different_host = true;
HostPortPair origin("www.example.org", 443);
HostPortPair alternative("mail.example.org", 443);
@@ -897,7 +893,6 @@ TEST_P(QuicNetworkTransactionTest, ForceQuicWithErrorConnecting) {
mock_quic_data1.AddSocketDataToFactory(&socket_factory_);
mock_quic_data2.AddSocketDataToFactory(&socket_factory_);
- params_.enable_alternative_service_with_different_host = false;
CreateSession();
EXPECT_EQ(0U, test_socket_performance_watcher_factory_.watcher_count());
@@ -927,7 +922,6 @@ TEST_P(QuicNetworkTransactionTest, DoNotForceQuicForHttps) {
SSLSocketDataProvider ssl(ASYNC, OK);
socket_factory_.AddSSLSocketDataProvider(&ssl);
- params_.enable_alternative_service_with_different_host = false;
CreateSession();
SendRequestAndExpectHttpResponse("hello world");
@@ -2136,7 +2130,6 @@ TEST_P(QuicNetworkTransactionTest, QuicUpload) {
// the alternate-protocol job will "win".
AddHangingNonAlternateProtocolSocketData();
- params_.enable_alternative_service_with_different_host = false;
CreateSession();
request_.method = "POST";
ChunkedUploadDataStream upload_data(0);
@@ -2181,7 +2174,6 @@ class QuicNetworkTransactionWithDestinationTest
MockCryptoClientStream::CONFIRM_HANDSHAKE);
params.quic_crypto_client_stream_factory = &crypto_client_stream_factory_;
- params.enable_alternative_service_with_different_host = true;
params.enable_quic = true;
params.quic_random = &random_generator_;
params.client_socket_factory = &socket_factory_;

Powered by Google App Engine
This is Rietveld 408576698