components/network_session_configurator/network_session_configurator_unittest.cc - Issue 2089243002: Split enable_alternative_service_with_different_host flag.

Unified Diff: components/network_session_configurator/network_session_configurator_unittest.cc

Issue 2089243002: Split enable_alternative_service_with_different_host flag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data_unittest.cc ('K') | « components/network_session_configurator/network_session_configurator.cc ('k') | jingle/glue/proxy_resolving_client_socket.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/network_session_configurator/network_session_configurator_unittest.cc

diff --git a/components/network_session_configurator/network_session_configurator_unittest.cc b/components/network_session_configurator/network_session_configurator_unittest.cc

index c1e5fdfc72af388cd23dab7bd40fcef51d65e638..861f071182c52dc9b689394d7e34ad0e904ba1da 100644

--- a/components/network_session_configurator/network_session_configurator_unittest.cc

+++ b/components/network_session_configurator/network_session_configurator_unittest.cc

@@ -57,7 +57,7 @@ TEST_F(NetworkSessionConfiguratorTest, Defaults) {

EXPECT_FALSE(params_.enable_spdy31);

EXPECT_TRUE(params_.enable_http2);

EXPECT_FALSE(params_.enable_tcp_fast_open_for_ssl);

- EXPECT_TRUE(params_.enable_alternative_service_with_different_host);

+ EXPECT_TRUE(params_.enable_quic_alternative_service_with_different_host);

EXPECT_FALSE(params_.enable_npn);

EXPECT_TRUE(params_.enable_priority_dependencies);

EXPECT_FALSE(params_.enable_quic);

@@ -195,7 +195,7 @@ TEST_F(NetworkSessionConfiguratorTest, EnableQuicFromFieldTrialGroup) {

EXPECT_FALSE(params_.quic_enable_non_blocking_io);

EXPECT_FALSE(params_.quic_disable_disk_cache);

EXPECT_FALSE(params_.quic_prefer_aes);

- EXPECT_TRUE(params_.enable_alternative_service_with_different_host);

+ EXPECT_TRUE(params_.enable_quic_alternative_service_with_different_host);

EXPECT_EQ(0, params_.quic_max_number_of_lossy_connections);

EXPECT_EQ(1.0f, params_.quic_packet_loss_threshold);

EXPECT_TRUE(params_.quic_delay_tcp_race);

@@ -259,7 +259,7 @@ TEST_F(NetworkSessionConfiguratorTest,

ParseFieldTrialsAndCommandLine();

EXPECT_FALSE(params_.enable_quic);

- EXPECT_TRUE(params_.enable_alternative_service_with_different_host);

+ EXPECT_TRUE(params_.enable_quic_alternative_service_with_different_host);

}

TEST_F(NetworkSessionConfiguratorTest,

@@ -271,7 +271,7 @@ TEST_F(NetworkSessionConfiguratorTest,

ParseFieldTrialsAndCommandLine();

EXPECT_TRUE(params_.enable_quic);

- EXPECT_TRUE(params_.enable_alternative_service_with_different_host);

+ EXPECT_TRUE(params_.enable_quic_alternative_service_with_different_host);

}

TEST_F(NetworkSessionConfiguratorTest, PacketLengthFromCommandLine) {

@@ -501,7 +501,7 @@ TEST_F(NetworkSessionConfiguratorTest,

ParseFieldTrials();

- EXPECT_TRUE(params_.enable_alternative_service_with_different_host);

+ EXPECT_TRUE(params_.enable_quic_alternative_service_with_different_host);

}

TEST_F(NetworkSessionConfiguratorTest,