Switch v8 inspector to stl collections

Switch v8 inspector to stl collections

V8 inspector will now be using only STL collections (std::vector,
std::unordered_set, std::unordered_map). protocol::HashMap and
protocol::HashSet remained, but became typedefs to STL types.

R=dgozman@chromium.org
TBR=pfeldman@chromium.org
BUG=

Committed: https://crrev.com/41ae7242e703dcd6fa6fc93d128d85de7a49c7b1
Cr-Commit-Position: refs/heads/master@{#402528}

[eostroukhov-old, 2016-06-21 23:59:25]

The CQ bit was checked by eostroukhov@google.com

[commit-bot: I haz the power, 2016-06-22 00:00:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2087953004/40001

[commit-bot: I haz the power, 2016-06-22 00:00:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-22 00:00:50]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[dgozman, 2016-06-24 17:01:14]

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/inspector_protocol/Values.h (right):

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/inspector_protocol/Values.h:185: if (isNew) {
style: redundant {}

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/InjectedScriptNative.cpp
(right):

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/InjectedScriptNative.cpp:82:
m_nameToObjectGroup.erase(groupName);
nit: erase(groupIt) would be even better

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp
(left):

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:1040: if
(!m_recurringTasks.contains(task))
This code is messed up.

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp
(right):

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:479:
m_pausedCallFrames.swap(frames);
I'm interested why previous code doesn't work anymore?

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:849:
JavaScriptCallFrame* frame = !m_pausedCallFrames.empty() ?
m_pausedCallFrames.front().get() : nullptr;
nit: I like [0] more than front()

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:1026: if
(stack_iter != m_asyncTaskStacks.end() && stack_iter->second) {
I think stack_iter->second cannot be nullptr.

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp (right):

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp:161: if (iter
!= m_sessions.end() && iter->second) {
iter->second is always non-null

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp:161: if (iter
!= m_sessions.end() && iter->second) {
Prefer early bail-out:
if (iter == m_sessions.end())
    return nullptr;

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp:163: if
(agent->enabled()) {
style: extra {}

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp:766:
m_contexts.insert(std::make_pair(info.contextGroupId, wrapUnique(new
ContextByIdMap()))).first->second;
I think this creates an extra ContextByIdMap most of the times just to delete
it.

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp:768:
DCHECK(contextById->find(contextId) == contextById->end());
cend?

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp:770: bool
inserted = contextById->insert(std::make_pair(contextId,
wrapUnique(context))).second;
Why not just
contextById[contextId] = wrapUnique(context);

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp:772:
SessionMap::iterator session = m_sessions.find(info.contextGroupId);
nit: sessionIt

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp:773: if
(session != m_sessions.end() && session->second) {
style: extra {}

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp:773: if
(session != m_sessions.end() && session->second) {
No need to check for session->second

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp:782: if
(!isContextInGroup(contextGroupId, contextId))
Let's make this method return InspectedContext* and just check it for null.

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp:798: if
(session != m_sessions.end() && session->second)
No need to check for session->second

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp:855: if
(contextGroupId) {
Prefer early return instead.

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h (right):

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h:155: bool
isContextInGroup(int groupId, int contextId) const
Please move implementation to cpp.

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp
(right):

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp:121:
auto context_iter = contexts->find(key);
Blink avoids abbreviations as much as possible, but for iterators the common one
is |it|:
context_iter -> contextIt

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp:122:
if (context_iter != contexts->end()) {
style: extra {}

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
(right):

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp:316: auto
iter = m_compiledScripts.find(scriptId);
iter -> it

[alph, 2016-06-24 17:37:27]

alph@chromium.org changed reviewers:
+ alph@chromium.org

[alph, 2016-06-24 17:37:28]

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp
(right):

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:1017:
auto stack_iter = m_asyncTaskStacks.find(task);
stackIt

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp
(right):

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp:172:
if (contexts) {
nit: here and everywhere:
if (!contexts) continue;

[eostroukhov-old, 2016-06-24 22:24:26]

Thank you for the review.

Please take another look - I fixed the comments and rebased the patch.

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/inspector_protocol/Values.h (right):

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/inspector_protocol/Values.h:185: if (isNew) {
On 2016/06/24 17:01:12, dgozman wrote:
> style: redundant {}

Done.

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/InjectedScriptNative.cpp
(right):

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/InjectedScriptNative.cpp:82:
m_nameToObjectGroup.erase(groupName);
On 2016/06/24 17:01:13, dgozman wrote:
> nit: erase(groupIt) would be even better

Done.

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp
(left):

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:1040: if
(!m_recurringTasks.contains(task))
On 2016/06/24 17:01:13, dgozman wrote:
> This code is messed up.

Done.

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp
(right):

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:479:
m_pausedCallFrames.swap(frames);
On 2016/06/24 17:01:13, dgozman wrote:
> I'm interested why previous code doesn't work anymore?

Compile error:
error: non-const lvalue reference to type 'vector<...>' cannot bind to a
temporary of type 'vector<...>'

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:849:
JavaScriptCallFrame* frame = !m_pausedCallFrames.empty() ?
m_pausedCallFrames.front().get() : nullptr;
On 2016/06/24 17:01:13, dgozman wrote:
> nit: I like [0] more than front()

Done.

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:1017:
auto stack_iter = m_asyncTaskStacks.find(task);
On 2016/06/24 17:37:27, alph wrote:
> stackIt

Done.

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:1026: if
(stack_iter != m_asyncTaskStacks.end() && stack_iter->second) {
On 2016/06/24 17:01:13, dgozman wrote:
> I think stack_iter->second cannot be nullptr.

Done.

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp (right):

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp:161: if (iter
!= m_sessions.end() && iter->second) {
On 2016/06/24 17:01:13, dgozman wrote:
> Prefer early bail-out:
> if (iter == m_sessions.end())
>     return nullptr;

Done.

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp:161: if (iter
!= m_sessions.end() && iter->second) {
On 2016/06/24 17:01:13, dgozman wrote:
> iter->second is always non-null

Done.

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp:163: if
(agent->enabled()) {
On 2016/06/24 17:01:13, dgozman wrote:
> style: extra {}

Done.

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp:766:
m_contexts.insert(std::make_pair(info.contextGroupId, wrapUnique(new
ContextByIdMap()))).first->second;
On 2016/06/24 17:01:13, dgozman wrote:
> I think this creates an extra ContextByIdMap most of the times just to delete
> it.

Done.

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp:768:
DCHECK(contextById->find(contextId) == contextById->end());
On 2016/06/24 17:01:13, dgozman wrote:
> cend?

Done.

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp:770: bool
inserted = contextById->insert(std::make_pair(contextId,
wrapUnique(context))).second;
On 2016/06/24 17:01:13, dgozman wrote:
> Why not just
> contextById[contextId] = wrapUnique(context);

Done.

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp:772:
SessionMap::iterator session = m_sessions.find(info.contextGroupId);
On 2016/06/24 17:01:13, dgozman wrote:
> nit: sessionIt

Done.

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp:773: if
(session != m_sessions.end() && session->second) {
On 2016/06/24 17:01:13, dgozman wrote:
> No need to check for session->second

Done.

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp:773: if
(session != m_sessions.end() && session->second) {
On 2016/06/24 17:01:13, dgozman wrote:
> style: extra {}

Done.

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp:782: if
(!isContextInGroup(contextGroupId, contextId))
On 2016/06/24 17:01:13, dgozman wrote:
> Let's make this method return InspectedContext* and just check it for null.

Done.

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp:798: if
(session != m_sessions.end() && session->second)
On 2016/06/24 17:01:13, dgozman wrote:
> No need to check for session->second

Done.

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp:855: if
(contextGroupId) {
On 2016/06/24 17:01:13, dgozman wrote:
> Prefer early return instead.

Done.

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h (right):

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h:155: bool
isContextInGroup(int groupId, int contextId) const
On 2016/06/24 17:01:13, dgozman wrote:
> Please move implementation to cpp.

Done.

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp
(right):

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp:121:
auto context_iter = contexts->find(key);
On 2016/06/24 17:01:13, dgozman wrote:
> Blink avoids abbreviations as much as possible, but for iterators the common
one
> is |it|:
> context_iter -> contextIt

Done.

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp:122:
if (context_iter != contexts->end()) {
On 2016/06/24 17:01:13, dgozman wrote:
> style: extra {}

Done.

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp:172:
if (contexts) {
On 2016/06/24 17:37:27, alph wrote:
> nit: here and everywhere:
> if (!contexts) continue;

Done.

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
(right):

https://codereview.chromium.org/2087953004/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp:316: auto
iter = m_compiledScripts.find(scriptId);
On 2016/06/24 17:01:14, dgozman wrote:
> iter -> it

Done.

[dgozman, 2016-06-24 23:31:47]

lgtm

https://codereview.chromium.org/2087953004/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp (right):

https://codereview.chromium.org/2087953004/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp:784:
m_contexts.find(groupId);
nit: place it on the same line

https://codereview.chromium.org/2087953004/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp:836: if
(session != m_sessions.end() && session->second)
Drop session->second check.

https://codereview.chromium.org/2087953004/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp:896: const
std::unique_ptr<V8StackTraceImpl>& stack = m_asyncTaskStacks[task];
It could be that m_asyncTasksStacks doesn't have task. In this case, we
shouldn't create an item there. We have to use find().

https://codereview.chromium.org/2087953004/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp
(right):

https://codereview.chromium.org/2087953004/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp:136:
auto contexts_iter = contexts ? contexts->find(contextId) : contexts->end();
contextsIt

[dgozman, 2016-06-24 23:32:08]

Description was changed from

==========
Switch inspector to stl collections

Inspector will now be using only STL collections (std::vector,
std::unordered_set, std::unordered_map). protocol::HashMap and
protocol::HashSet remained, but became typedefs to STL types.

R=dgozman@chromium.org, pfeldman@chromium.org
BUG=
==========

to

==========
Switch v8 inspector to stl collections

V8 inspector will now be using only STL collections (std::vector,
std::unordered_set, std::unordered_map). protocol::HashMap and
protocol::HashSet remained, but became typedefs to STL types.

R=dgozman@chromium.org, pfeldman@chromium.org
BUG=
==========

[eostroukhov-old, 2016-06-28 00:11:22]

The CQ bit was checked by eostroukhov@google.com

[eostroukhov-old, 2016-06-28 00:11:22]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2087953004/#ps160001
(title: "Code review comments")

[eostroukhov-old, 2016-06-28 00:11:43]

On 2016/06/24 23:31:47, dgozman wrote:
> lgtm
> 
>
https://codereview.chromium.org/2087953004/diff/140001/third_party/WebKit/Sou...
> File third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp
(right):
> 
>
https://codereview.chromium.org/2087953004/diff/140001/third_party/WebKit/Sou...
> third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp:784:
> m_contexts.find(groupId);
> nit: place it on the same line
> 
>
https://codereview.chromium.org/2087953004/diff/140001/third_party/WebKit/Sou...
> third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp:836: if
> (session != m_sessions.end() && session->second)
> Drop session->second check.
> 
>
https://codereview.chromium.org/2087953004/diff/140001/third_party/WebKit/Sou...
> third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp:896: const
> std::unique_ptr<V8StackTraceImpl>& stack = m_asyncTaskStacks[task];
> It could be that m_asyncTasksStacks doesn't have task. In this case, we
> shouldn't create an item there. We have to use find().
> 
>
https://codereview.chromium.org/2087953004/diff/140001/third_party/WebKit/Sou...
> File
third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp
> (right):
> 
>
https://codereview.chromium.org/2087953004/diff/140001/third_party/WebKit/Sou...
>
third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp:136:
> auto contexts_iter = contexts ? contexts->find(contextId) : contexts->end();
> contextsIt

I addressed all these comments.

[commit-bot: I haz the power, 2016-06-28 00:12:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 00:23:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-28 00:23:24]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[eostroukhov-old, 2016-06-28 18:22:27]

Description was changed from

==========
Switch v8 inspector to stl collections

V8 inspector will now be using only STL collections (std::vector,
std::unordered_set, std::unordered_map). protocol::HashMap and
protocol::HashSet remained, but became typedefs to STL types.

R=dgozman@chromium.org, pfeldman@chromium.org
BUG=
==========

to

==========
Switch v8 inspector to stl collections

V8 inspector will now be using only STL collections (std::vector,
std::unordered_set, std::unordered_map). protocol::HashMap and
protocol::HashSet remained, but became typedefs to STL types.

R=dgozman@chromium.org
TBR=pfeldman@chromium.org
BUG=
==========

[eostroukhov-old, 2016-06-28 18:41:50]

The CQ bit was checked by eostroukhov@google.com

[eostroukhov-old, 2016-06-28 18:41:50]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2087953004/#ps180001
(title: "Rebase")

[commit-bot: I haz the power, 2016-06-28 18:42:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 20:26:54]

Description was changed from

==========
Switch v8 inspector to stl collections

V8 inspector will now be using only STL collections (std::vector,
std::unordered_set, std::unordered_map). protocol::HashMap and
protocol::HashSet remained, but became typedefs to STL types.

R=dgozman@chromium.org
TBR=pfeldman@chromium.org
BUG=
==========

to

==========
Switch v8 inspector to stl collections

V8 inspector will now be using only STL collections (std::vector,
std::unordered_set, std::unordered_map). protocol::HashMap and
protocol::HashSet remained, but became typedefs to STL types.

R=dgozman@chromium.org
TBR=pfeldman@chromium.org
BUG=
==========

[commit-bot: I haz the power, 2016-06-28 20:26:55]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2016-06-28 20:29:45]

Description was changed from

==========
Switch v8 inspector to stl collections

V8 inspector will now be using only STL collections (std::vector,
std::unordered_set, std::unordered_map). protocol::HashMap and
protocol::HashSet remained, but became typedefs to STL types.

R=dgozman@chromium.org
TBR=pfeldman@chromium.org
BUG=
==========

to

==========
Switch v8 inspector to stl collections

V8 inspector will now be using only STL collections (std::vector,
std::unordered_set, std::unordered_map). protocol::HashMap and
protocol::HashSet remained, but became typedefs to STL types.

R=dgozman@chromium.org
TBR=pfeldman@chromium.org
BUG=

Committed: https://crrev.com/41ae7242e703dcd6fa6fc93d128d85de7a49c7b1
Cr-Commit-Position: refs/heads/master@{#402528}
==========

[commit-bot: I haz the power, 2016-06-28 20:29:46]

Patchset 10 (id:??) landed as
https://crrev.com/41ae7242e703dcd6fa6fc93d128d85de7a49c7b1
Cr-Commit-Position: refs/heads/master@{#402528}