third_party/WebKit/Source/platform/inspector_protocol/ErrorSupport.cpp - Issue 2087953004: Switch v8 inspector to stl collections

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/inspector_protocol/ErrorSupport.cpp

Issue 2087953004: Switch v8 inspector to stl collections (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/inspector_protocol/ErrorSupport.h ('k') | third_party/WebKit/Source/platform/inspector_protocol/String16WTF.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/inspector_protocol/ErrorSupport.cpp

diff --git a/third_party/WebKit/Source/platform/inspector_protocol/ErrorSupport.cpp b/third_party/WebKit/Source/platform/inspector_protocol/ErrorSupport.cpp

index dc9e66373ee2710a08eddca61eccbbc052358c70..4f58a396f0d8b52966851884fb3538f40e50c6a3 100644

--- a/third_party/WebKit/Source/platform/inspector_protocol/ErrorSupport.cpp

+++ b/third_party/WebKit/Source/platform/inspector_protocol/ErrorSupport.cpp

@@ -29,12 +29,12 @@ void ErrorSupport::setName(const String16& name)

void ErrorSupport::push()

{

- m_path.append(String16());

+ m_path.push_back(String16());

}

void ErrorSupport::pop()

{

- m_path.removeLast();

+ m_path.pop_back();

}

void ErrorSupport::addError(const String16& error)

@@ -47,7 +47,7 @@ void ErrorSupport::addError(const String16& error)

}

builder.append(": ");

builder.append(error);

- m_errors.append(builder.toString());

+ m_errors.push_back(builder.toString());

}

bool ErrorSupport::hasErrors()