Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 208793005: Remove JavaScript execution from RenderViewHost. (Closed)

Created:
6 years, 9 months ago by Avi (use Gerrit)
Modified:
6 years, 8 months ago
Reviewers:
Tom Sepez, jam
CC:
chromium-reviews, creis+watch_chromium.org, nasko+codewatch_chromium.org, joi+watch-content_chromium.org, robertshield, darin-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Remove JavaScript execution from RenderViewHost. BUG=304341, 316203 TEST=no change TBR=tsepez@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260910

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -177 lines) Patch
M chrome/browser/automation/testing_automation_provider.cc View 1 2 1 chunk +3 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.h View 1 2 3 chunks +0 lines, -13 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 2 3 chunks +0 lines, -39 lines 0 comments Download
M content/common/view_messages.h View 1 2 2 chunks +0 lines, -37 lines 0 comments Download
M content/public/browser/render_view_host.h View 1 1 chunk +0 lines, -14 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 2 2 chunks +0 lines, -9 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 3 chunks +0 lines, -60 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Avi (use Gerrit)
6 years, 9 months ago (2014-03-25 19:54:57 UTC) #1
Avi (use Gerrit)
On 2014/03/25 19:54:57, Avi wrote: John, just say when... :)
6 years, 9 months ago (2014-03-25 19:55:09 UTC) #2
jam
On 2014/03/25 19:55:09, Avi wrote: > On 2014/03/25 19:54:57, Avi wrote: > > John, just ...
6 years, 9 months ago (2014-03-25 22:52:59 UTC) #3
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org
6 years, 8 months ago (2014-04-01 14:48:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/208793005/90001
6 years, 8 months ago (2014-04-01 14:48:14 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-01 15:29:08 UTC) #6
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=58798
6 years, 8 months ago (2014-04-01 15:29:09 UTC) #7
Avi (use Gerrit)
tom, officially for the IPCs.
6 years, 8 months ago (2014-04-01 15:31:34 UTC) #8
Avi (use Gerrit)
On 2014/04/01 15:31:34, Avi wrote: > tom, officially for the IPCs. TBRing: it should be ...
6 years, 8 months ago (2014-04-01 15:32:13 UTC) #9
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org
6 years, 8 months ago (2014-04-01 15:32:17 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/208793005/90001
6 years, 8 months ago (2014-04-01 15:32:25 UTC) #11
commit-bot: I haz the power
6 years, 8 months ago (2014-04-01 18:37:29 UTC) #12
Message was sent while issue was closed. 
Change committed as 260910

Powered by Google App Engine
This is Rietveld 408576698