Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(772)

Unified Diff: content/browser/renderer_host/render_view_host_impl.h

Issue 208793005: Remove JavaScript execution from RenderViewHost. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: rebase Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_view_host_impl.h
diff --git a/content/browser/renderer_host/render_view_host_impl.h b/content/browser/renderer_host/render_view_host_impl.h
index 9dbd360e956471e9e75231627d068714674b6fd3..1ebb3a81b2f5967cd865675a442f42cb4a78681f 100644
--- a/content/browser/renderer_host/render_view_host_impl.h
+++ b/content/browser/renderer_host/render_view_host_impl.h
@@ -200,13 +200,6 @@ class CONTENT_EXPORT RenderViewHostImpl
virtual void ExecuteMediaPlayerActionAtLocation(
const gfx::Point& location,
const blink::WebMediaPlayerAction& action) OVERRIDE;
- virtual void ExecuteJavascriptInWebFrame(
- const base::string16& frame_xpath,
- const base::string16& jscript) OVERRIDE;
- virtual void ExecuteJavascriptInWebFrameCallbackResult(
- const base::string16& frame_xpath,
- const base::string16& jscript,
- const JavascriptResultCallback& callback) OVERRIDE;
virtual void ExecutePluginActionAtLocation(
const gfx::Point& location,
const blink::WebPluginAction& action) OVERRIDE;
@@ -573,7 +566,6 @@ class CONTENT_EXPORT RenderViewHostImpl
const std::vector<AccessibilityHostMsg_EventParams>& params);
void OnAccessibilityLocationChanges(
const std::vector<AccessibilityHostMsg_LocationChangeParams>& params);
- void OnScriptEvalResponse(int id, const base::ListValue& result);
void OnDidZoomURL(double zoom_level, bool remember, const GURL& url);
void OnRequestDesktopNotificationPermission(const GURL& origin,
int callback_id);
@@ -680,11 +672,6 @@ class CONTENT_EXPORT RenderViewHostImpl
bool are_javascript_messages_suppressed_;
- // The mapping of pending javascript calls created by
- // ExecuteJavascriptInWebFrameCallbackResult and their corresponding
- // callbacks.
- std::map<int, JavascriptResultCallback> javascript_callbacks_;
-
// Accessibility callback for testing.
base::Callback<void(ui::AXEvent)> accessibility_testing_callback_;
« no previous file with comments | « chrome/browser/automation/testing_automation_provider.cc ('k') | content/browser/renderer_host/render_view_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698