Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: chrome/browser/automation/testing_automation_provider.cc

Issue 208793005: Remove JavaScript execution from RenderViewHost. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: rebase Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/renderer_host/render_view_host_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/automation/testing_automation_provider.cc
diff --git a/chrome/browser/automation/testing_automation_provider.cc b/chrome/browser/automation/testing_automation_provider.cc
index 12fc4d3f420db621d73a105d5ae3e1d8a21b9793..0c86a931b1908d21597f6cac63df846e4514b2ef 100644
--- a/chrome/browser/automation/testing_automation_provider.cc
+++ b/chrome/browser/automation/testing_automation_provider.cc
@@ -1016,11 +1016,9 @@ void TestingAutomationProvider::ExecuteJavascriptInRenderViewFrame(
// This routing id needs to be remembered for the reverse
// communication while sending back the response of
// this javascript execution.
- render_view_host->ExecuteJavascriptInWebFrame(
- frame_xpath,
- base::ASCIIToUTF16("window.domAutomationController.setAutomationId(0);"));
- render_view_host->ExecuteJavascriptInWebFrame(
- frame_xpath, script);
+
+ // Automation is dead. http://crbug.com/316203
+ NOTREACHED() << "Automation is dead.";
}
void TestingAutomationProvider::ExecuteJavascript(
« no previous file with comments | « no previous file | content/browser/renderer_host/render_view_host_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698