Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2087743002: Add Enterprise Policy for whitelisting hosts as exempt from CT (Closed)

Created:
4 years, 6 months ago by Ryan Sleevi
Modified:
4 years, 5 months ago
CC:
chromium-reviews, tnagel+watch_chromium.org, asvitkine+watch_chromium.org, awhalley
Base URL:
https://chromium.googlesource.com/chromium/src.git@symantec_ct
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Enterprise Policy for whitelisting hosts as exempt from CT Add a policy setting that allows hosts to be exempted from any Certificate Transparency requirements. Some CAs, such as Symantec and CNNIC at present, are required to disclose their certificates via CT in order to have them trusted; any certificate not disclosed will not be trusted. However, to accomodate some enterprise users who are not yet prepared to disclose their certificates (e.g. certificates for "topsecret.internal.example.com"), but wish to use these CAs, allow some hosts to be whitelisted as exempt from disclosure. Whether or not this policy is temporary depends on if the IETF and the CA community can come up with appropriate technical and procedural safeguards to allow 'redacting' the certificate, hiding portions of the hostname from disclosure. For now and the forseeable future, redaction is not viable, so the enterprise policy offers a suitable release valve. BUG=620178

Patch Set 1 #

Total comments: 5

Patch Set 2 : Rebased #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -1 line) Patch
M chrome/test/data/policy/policy_test_cases.json View 1 1 chunk +8 lines, -0 lines 0 comments Download
M components/policy/resources/policy_templates.json View 1 2 chunks +29 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 14 (3 generated)
Ryan Sleevi
Drew: With tnagel and bartfab OOO this week, I sadly must push to you. Primarily ...
4 years, 6 months ago (2016-06-21 04:10:10 UTC) #2
Ryan Sleevi
Also unclear: Whether we want to use the URLBlacklist format if we only care about ...
4 years, 6 months ago (2016-06-21 04:32:40 UTC) #3
Andrew T Wilson (Slow)
LGTM, but adding tnagel to chime in on the policy format (using URLBlacklist format) https://codereview.chromium.org/2087743002/diff/1/components/policy/resources/policy_templates.json ...
4 years, 6 months ago (2016-06-21 08:37:48 UTC) #5
Thiemo Nagel
https://codereview.chromium.org/2087743002/diff/1/chrome/test/data/policy/policy_test_cases.json File chrome/test/data/policy/policy_test_cases.json (right): https://codereview.chromium.org/2087743002/diff/1/chrome/test/data/policy/policy_test_cases.json#newcode1872 chrome/test/data/policy/policy_test_cases.json:1872: "test_policy": { "CertificateTransparencyEnforcementDisabledForUrls": ["google.com"] }, Nit: Please use example.com. ...
4 years, 6 months ago (2016-06-21 10:54:06 UTC) #7
Ryan Sleevi
https://codereview.chromium.org/2087743002/diff/1/components/policy/resources/policy_templates.json File components/policy/resources/policy_templates.json (right): https://codereview.chromium.org/2087743002/diff/1/components/policy/resources/policy_templates.json#newcode7942 components/policy/resources/policy_templates.json:7942: This policy allows certificates for the hostnames in the ...
4 years, 6 months ago (2016-06-21 17:01:01 UTC) #8
Andrew T Wilson (Slow)
On 2016/06/21 17:01:01, Ryan Sleevi wrote: > https://codereview.chromium.org/2087743002/diff/1/components/policy/resources/policy_templates.json > File components/policy/resources/policy_templates.json (right): > > https://codereview.chromium.org/2087743002/diff/1/components/policy/resources/policy_templates.json#newcode7942 ...
4 years, 6 months ago (2016-06-21 17:41:16 UTC) #9
Ryan Sleevi
On 2016/06/21 17:41:16, Andrew T Wilson (Slow) wrote: > The only rationale I could think ...
4 years, 6 months ago (2016-06-21 17:52:48 UTC) #10
Andrew T Wilson (Slow)
On 2016/06/21 17:52:48, Ryan Sleevi wrote: > On 2016/06/21 17:41:16, Andrew T Wilson (Slow) wrote: ...
4 years, 6 months ago (2016-06-22 15:01:01 UTC) #11
chromium-reviews
On Wed, Jun 22, 2016 at 8:01 AM, <atwilson@chromium.org> wrote: > On 2016/06/21 17:52:48, Ryan ...
4 years, 6 months ago (2016-06-22 15:25:56 UTC) #12
Ryan Sleevi
On 2016/06/22 15:25:56, chromium-reviews wrote: > > 2) Add the specific server certificate to your ...
4 years, 6 months ago (2016-06-22 15:38:14 UTC) #13
Andrew T Wilson (Slow)
4 years, 6 months ago (2016-06-23 08:28:15 UTC) #14
On 2016/06/22 15:38:14, Ryan Sleevi wrote:
> On 2016/06/22 15:25:56, chromium-reviews wrote:
> > > 2) Add the specific server certificate to your list of trust roots on your
> > > managed system running chrome (because I presume this would circumvent
> > > chrome's
> > > CA CT check, because we wouldn't need to follow the chain of trust up to a
> > > public CA)
> > >
> > > Given that #2 would be sufficient for their needs, why do we need to
> > > support #1?
> > >
> > 
> > I presume that they don't want to run two parallel PKIs, one private that
> > they can install on systems running Chrome, and one public that is used on
> > systems not running chrome but that can't have their trust stores updated.
> 
> Right, I think the issue Drew is that #2 isn't sufficient for their needs. You
> can't just add the specific server list to the set of CAs - that doesn't
change
> the logic and enforcement (it also doesn't work if done at a
server-certificate
> and not intermediate) level.
> 
> They would have to fully change their system to a private PKI and *then* use
#2.
> But if they change to the private PKI, then that breaks those LOB systems they
> don't manage, so they claim, and so they claim they can't change to a private
> PKI and use #2. So that's why this is offered - it adds the exception to the
> managed system, since they can't add the trust to the unmanaged systems.

OK, I understand now why #2 doesn't work - thanks for clarifying.

Powered by Google App Engine
This is Rietveld 408576698