Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 2083913002: Add error strings for CERT_STATUS_CERTIFICATE_TRANSPARENCY_REQUIRED (Closed)

Created:
4 years, 6 months ago by Ryan Sleevi
Modified:
4 years, 5 months ago
Reviewers:
felt
CC:
chromium-reviews, ainslie, rachelis, edwardjung
Base URL:
https://chromium.googlesource.com/chromium/src.git@symantec_ct
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add error strings for CERT_STATUS_CERTIFICATE_TRANSPARENCY_REQUIRED Add error text for CERT_STATUS_CERTIFICATE_TRANSPARENCY_REQUIRED, which is triggered when a certificate is required to be disclosed via Certificate Transparency (either intrinsic to the cert or because the site is configured to require that for all of its certs) BUG=620178 Committed: https://crrev.com/41b3461991dc5869407b9b2f17e086c0801bb522 Cr-Commit-Position: refs/heads/master@{#403015}

Patch Set 1 #

Patch Set 2 : One more enum update #

Patch Set 3 : Rebased #

Patch Set 4 : Review feedback #

Total comments: 2

Patch Set 5 : protocol -> policy per file strings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
M components/ssl_errors/error_info.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/ssl_errors/error_info.cc View 4 chunks +10 lines, -0 lines 0 comments Download
M components/ssl_errors_strings.grdp View 1 2 3 4 2 chunks +8 lines, -1 line 0 comments Download
M content/browser/ssl/ssl_policy.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Ryan Sleevi
Felt: Would you kindly? (chrome-ui-review signed off, with ainslie/rachel/ed giving the OK)
4 years, 5 months ago (2016-06-29 17:58:56 UTC) #2
felt
lgtm https://codereview.chromium.org/2083913002/diff/60001/components/ssl_errors_strings.grdp File components/ssl_errors_strings.grdp (right): https://codereview.chromium.org/2083913002/diff/60001/components/ssl_errors_strings.grdp#newcode165 components/ssl_errors_strings.grdp:165: nit: stray change at EOL?
4 years, 5 months ago (2016-06-29 19:33:05 UTC) #3
Ryan Sleevi
https://codereview.chromium.org/2083913002/diff/60001/components/ssl_errors_strings.grdp File components/ssl_errors_strings.grdp (right): https://codereview.chromium.org/2083913002/diff/60001/components/ssl_errors_strings.grdp#newcode165 components/ssl_errors_strings.grdp:165: On 2016/06/29 19:33:05, felt wrote: > nit: stray change ...
4 years, 5 months ago (2016-06-29 23:03:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2083913002/80001
4 years, 5 months ago (2016-06-29 23:07:02 UTC) #7
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 5 months ago (2016-06-30 00:18:38 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 00:18:42 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 00:21:03 UTC) #11
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/41b3461991dc5869407b9b2f17e086c0801bb522
Cr-Commit-Position: refs/heads/master@{#403015}

Powered by Google App Engine
This is Rietveld 408576698