Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2087503002: Getting enums for free. (Closed)

Created:
4 years, 6 months ago by ahe
Modified:
4 years, 6 months ago
Reviewers:
kasperl
CC:
rasta-dart+reviews_googlegroups.com
Base URL:
git@github.com:dart-lang/rasta.git@prune_unsupported
Target Ref:
refs/heads/master
Project:
Rasta
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -4 lines) Patch
M lib/kernel_visitor.dart View 1 chunk +6 lines, -2 lines 0 comments Download
A + test/kernel/regression/enum.dart View 1 chunk +3 lines, -2 lines 0 comments Download
A test/kernel/regression/enum.dart.txt View 1 chunk +15 lines, -0 lines 1 comment Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 6 (2 generated)
ahe
That was easy :-)
4 years, 6 months ago (2016-06-20 16:58:39 UTC) #2
ahe
FYI https://codereview.chromium.org/2087503002/diff/1/test/kernel/regression/enum.dart.txt File test/kernel/regression/enum.dart.txt (right): https://codereview.chromium.org/2087503002/diff/1/test/kernel/regression/enum.dart.txt#newcode14 test/kernel/regression/enum.dart.txt:14: return const <dynamic, dynamic>{0: "Foo.ec1", 1: "Foo.ec2"}.[](this.index); This ...
4 years, 6 months ago (2016-06-20 17:27:26 UTC) #3
kasperl
LGTM.
4 years, 6 months ago (2016-06-20 20:12:59 UTC) #4
ahe
4 years, 6 months ago (2016-06-21 11:13:38 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b4fd947cd9ac1a34d783ecc8767f50b46ead02aa (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698