Getting enums for free.

Getting enums for free.

R=kasperl@google.com

Committed: https://github.com/dart-lang/rasta/commit/b4fd947cd9ac1a34d783ecc8767f50b46ead02aa

[ahe, 2016-06-20 16:58:38]

ahe@google.com changed reviewers:
+ kasperl@google.com

[ahe, 2016-06-20 16:58:39]

That was easy :-)

[ahe, 2016-06-20 17:27:26]

FYI

https://codereview.chromium.org/2087503002/diff/1/test/kernel/regression/enum...
File test/kernel/regression/enum.dart.txt (right):

https://codereview.chromium.org/2087503002/diff/1/test/kernel/regression/enum...
test/kernel/regression/enum.dart.txt:14: return const <dynamic, dynamic>{0:
"Foo.ec1", 1: "Foo.ec2"}.[](this.index);
This looks a bit odd, but I assume this is to simplify tree-shaking:

Because the names are in a map, individual enum constants can be removed if they
aren't needed.

Because the names aren't stored directly in the constants, the names can be
omitted if the toString method is never called.

[kasperl, 2016-06-20 20:12:59]

LGTM.

[ahe, 2016-06-21 11:13:36]

Description was changed from

==========
Getting enums for free.
==========

to

==========
Getting enums for free.

R=kasperl@google.com

Committed:
https://github.com/dart-lang/rasta/commit/b4fd947cd9ac1a34d783ecc8767f50b46ea...
==========

[ahe, 2016-06-21 11:13:38]

Committed patchset #1 (id:1) manually as
b4fd947cd9ac1a34d783ecc8767f50b46ead02aa (presubmit successful).