Reduce usage of buildUnsupported.

Reduce usage of buildUnsupported.

R=kasperl@google.com

Committed: https://github.com/dart-lang/rasta/commit/5824246f27ce0c32eac9e7d299e3805d2c2a314e

[ahe, 2016-06-20 16:31:07]

ahe@google.com changed reviewers:
+ kasperl@google.com

[kasperl, 2016-06-20 20:10:18]

LGTM.

https://codereview.chromium.org/2080783002/diff/1/lib/kernel_visitor.dart
File lib/kernel_visitor.dart (right):

https://codereview.chromium.org/2080783002/diff/1/lib/kernel_visitor.dart#new...
lib/kernel_visitor.dart:709: // Shouldn't normally be called. Handled by
[visitSwitchCase].
What does normally mean in this context? That it might happen? Can you drop
normally from this and other similar comments?

[ahe, 2016-06-21 10:51:05]

Thank you, Kasper.

I don't like when programs crash and tell me "shouldn't happen" or "can't
happen". So I tend to overcompensate, even in comments. I think "shouldn't/can't
happen" are fine in comments. Not in errors that a user will see if there's a
bug.

https://codereview.chromium.org/2080783002/diff/1/lib/kernel_visitor.dart
File lib/kernel_visitor.dart (right):

https://codereview.chromium.org/2080783002/diff/1/lib/kernel_visitor.dart#new...
lib/kernel_visitor.dart:709: // Shouldn't normally be called. Handled by
[visitSwitchCase].
On 2016/06/20 20:10:18, kasperl wrote:
> What does normally mean in this context? That it might happen? Can you drop
> normally from this and other similar comments?

Done.

[ahe, 2016-06-21 10:52:17]

Description was changed from

==========
Reduce usage of buildUnsupported.
==========

to

==========
Reduce usage of buildUnsupported.

R=kasperl@google.com

Committed:
https://github.com/dart-lang/rasta/commit/5824246f27ce0c32eac9e7d299e3805d2c2...
==========

[ahe, 2016-06-21 10:52:19]

Committed patchset #2 (id:20001) manually as
5824246f27ce0c32eac9e7d299e3805d2c2a314e (presubmit successful).