Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 2085613002: Constant get and invoke are never called. (Closed)

Created:
4 years, 6 months ago by ahe
Modified:
4 years, 6 months ago
Reviewers:
kasperl
CC:
rasta-dart+reviews_googlegroups.com
Base URL:
git@github.com:dart-lang/rasta.git@enum
Target Ref:
refs/heads/master
Project:
Rasta
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -11 lines) Patch
M lib/kernel_visitor.dart View 1 chunk +6 lines, -4 lines 0 comments Download
A + test/kernel/regression/constant_get_and_invoke.dart View 1 chunk +3 lines, -5 lines 0 comments Download
A + test/kernel/regression/constant_get_and_invoke.dart.txt View 1 chunk +3 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 5 (2 generated)
ahe
4 years, 6 months ago (2016-06-20 17:06:59 UTC) #2
kasperl
LGTM.
4 years, 6 months ago (2016-06-20 20:10:44 UTC) #3
ahe
4 years, 6 months ago (2016-06-21 11:16:46 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b6d085bb468d1d1c7ae097f281cca3c550ae3686 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698