Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2087393003: Fix Rob's nits from https://codereview.chromium.org/2085913003 (Closed)

Created:
4 years, 6 months ago by bsalomon
Modified:
4 years, 6 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : cleaner #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -13 lines) Patch
M src/gpu/GrShape.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/GrShapeTest.cpp View 1 2 chunks +16 lines, -12 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 6 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2087393003/20001
4 years, 6 months ago (2016-06-23 19:03:29 UTC) #3
robertphillips
lgtm
4 years, 6 months ago (2016-06-23 19:12:28 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 19:23:11 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/ac5fcea9c3ec32a87bfd8cb96531e82097a1d861

Powered by Google App Engine
This is Rietveld 408576698