Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2070643002: Add some more getters to GrShape. (Closed)

Created:
4 years, 6 months ago by bsalomon
Modified:
4 years, 6 months ago
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@moreshapestuf
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add some more getters to GrShape. These will be used to deploy GrShape in GrPathRenderer subclasses. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2070643002 Committed: https://skia.googlesource.com/skia/+/425c27fab9d82d19b0bce7c091533d546465bbae

Patch Set 1 #

Patch Set 2 : cl dependency #

Patch Set 3 : fix gcc warning #

Patch Set 4 : rebase #

Patch Set 5 : update #

Total comments: 2

Patch Set 6 : rm extra space #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -5 lines) Patch
M src/gpu/GrShape.h View 1 2 3 4 5 4 chunks +60 lines, -2 lines 0 comments Download
M tests/GrShapeTest.cpp View 1 2 3 4 4 chunks +24 lines, -3 lines 0 comments Download

Depends on Patchset:

Issue 2087393003 Patch 20001

Dependent Patchsets:

Issue 2099473002 Patch 1
Issue 2081383006 Patch 1
Issue 2081383006 Patch 20001

Messages

Total messages: 11 (6 generated)
bsalomon
4 years, 6 months ago (2016-06-23 19:38:55 UTC) #4
robertphillips
lgtm https://codereview.chromium.org/2070643002/diff/80001/src/gpu/GrShape.h File src/gpu/GrShape.h (right): https://codereview.chromium.org/2070643002/diff/80001/src/gpu/GrShape.h#newcode251 src/gpu/GrShape.h:251: case Type::kRRect: extra space ?
4 years, 6 months ago (2016-06-23 19:52:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2070643002/100001
4 years, 6 months ago (2016-06-23 19:57:31 UTC) #8
bsalomon
https://codereview.chromium.org/2070643002/diff/80001/src/gpu/GrShape.h File src/gpu/GrShape.h (right): https://codereview.chromium.org/2070643002/diff/80001/src/gpu/GrShape.h#newcode251 src/gpu/GrShape.h:251: case Type::kRRect: On 2016/06/23 19:52:20, robertphillips wrote: > extra ...
4 years, 6 months ago (2016-06-23 19:57:32 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 20:18:49 UTC) #11
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/425c27fab9d82d19b0bce7c091533d546465bbae

Powered by Google App Engine
This is Rietveld 408576698