Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Issue 2085913003: Canonicalize path fill types for stroked paths in GrShape. (Closed)

Created:
4 years, 6 months ago by bsalomon
Modified:
4 years, 6 months ago
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@canonicalize_paths
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Canonicalize path fill types for stroked paths in GrShape. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2085913003 Committed: https://skia.googlesource.com/skia/+/a4817afe5095b67a68c907ff2e48e3e07907140c

Patch Set 1 #

Patch Set 2 : minor cleanup #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -26 lines) Patch
M src/gpu/GrShape.h View 2 chunks +7 lines, -2 lines 0 comments Download
M src/gpu/GrShape.cpp View 1 1 chunk +19 lines, -21 lines 1 comment Download
M tests/GrShapeTest.cpp View 1 3 chunks +32 lines, -3 lines 1 comment Download

Messages

Total messages: 20 (9 generated)
bsalomon
Follow-up to the last CL to standardize the fill type for stroked paths.
4 years, 6 months ago (2016-06-21 17:28:42 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2085913003/1
4 years, 6 months ago (2016-06-22 13:39:59 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-22 14:04:54 UTC) #7
bsalomon
ping
4 years, 6 months ago (2016-06-23 13:42:39 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2085913003/20001
4 years, 6 months ago (2016-06-23 15:31:26 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-23 15:51:56 UTC) #12
bsalomon
ping again, this is a small CL.
4 years, 6 months ago (2016-06-23 18:34:43 UTC) #13
egdaniel
sorry for delay, lgtm
4 years, 6 months ago (2016-06-23 18:43:52 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2085913003/20001
4 years, 6 months ago (2016-06-23 18:45:32 UTC) #16
robertphillips
lgtm https://codereview.chromium.org/2085913003/diff/20001/src/gpu/GrShape.cpp File src/gpu/GrShape.cpp (right): https://codereview.chromium.org/2085913003/diff/20001/src/gpu/GrShape.cpp#newcode339 src/gpu/GrShape.cpp:339: // Moreover, dashing ignores inverseness (skbug.com/5421) why fStyle ...
4 years, 6 months ago (2016-06-23 18:47:54 UTC) #18
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 18:48:30 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/a4817afe5095b67a68c907ff2e48e3e07907140c

Powered by Google App Engine
This is Rietveld 408576698