Add GM for hard stop gradients

Add GM for hard stop gradients

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2087273002

Committed: https://skia.googlesource.com/skia/+/17b64b2fd4df538ec952b128a07dbf6ae0afe990

[fmenozzi, 2016-06-22 13:24:46]

Description was changed from

==========
Add GM for hard stop gradients

BUG=skia:
==========

to

==========
Add GM for hard stop gradients

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2087273002
==========

[fmenozzi, 2016-06-22 13:38:42]

fmenozzi@google.com changed reviewers:
+ tomhudson@google.com

[fmenozzi, 2016-06-22 13:38:42]

PTAL

Highlights different gradients (2-color, 3-color, 5-color with hard stops and
various edge cases) with different tile modes (clamp, repeat, mirror).

[fmenozzi, 2016-06-22 14:49:58]

Added comment describing table

[tomhudson, 2016-06-22 15:28:49]

https://codereview.chromium.org/2087273002/diff/20001/gm/hardstop_gradients.cpp
File gm/hardstop_gradients.cpp (right):

https://codereview.chromium.org/2087273002/diff/20001/gm/hardstop_gradients.c...
gm/hardstop_gradients.cpp:15: * starts and ends at 30 pixel offsets on either
side of the rectangle.
starts and ends 30 pixels inset from either end of the rectangle?

https://codereview.chromium.org/2087273002/diff/20001/gm/hardstop_gradients.c...
gm/hardstop_gradients.cpp:25: * The last two rows are edge cases; the LAST two
t-values in edge case 1
Nit: omit the first 7 words.

https://codereview.chromium.org/2087273002/diff/20001/gm/hardstop_gradients.c...
gm/hardstop_gradients.cpp:60: static void getPoints(int cell_row, int cell_col,
SkPoint points[2]) {
Invest in better naming. Or maybe a comment.

https://codereview.chromium.org/2087273002/diff/20001/gm/hardstop_gradients.c...
gm/hardstop_gradients.cpp:71: static int getCount(int cell_row) {
Count of what?

static int numGradientColors()?

https://codereview.chromium.org/2087273002/diff/20001/gm/hardstop_gradients.c...
gm/hardstop_gradients.cpp:80: static SkShader::TileMode getTileMode(int
cell_col) {
This could be an array? Or would that be uglier?

[fmenozzi, 2016-06-22 15:47:52]

- Changed wording in comment
- Removed two unnecessary functions and used arrays instead
- Changed function name from getPoints() to createGradientPoints()

[tomhudson, 2016-06-22 15:54:06]

https://codereview.chromium.org/2087273002/diff/40001/gm/hardstop_gradients.cpp
File gm/hardstop_gradients.cpp (right):

https://codereview.chromium.org/2087273002/diff/40001/gm/hardstop_gradients.c...
gm/hardstop_gradients.cpp:123: for (int cell_row = 0; cell_row < NUM_ROWS;
cell_row++) {
Nit: revisit this function after reading https://skia.org/dev/contrib/style.

Otherwise LGTM

[fmenozzi, 2016-06-22 17:40:47]

Follow style guidelines

[fmenozzi, 2016-06-22 18:44:55]

The CQ bit was checked by fmenozzi@google.com

[fmenozzi, 2016-06-22 18:44:55]

The patchset sent to the CQ was uploaded after l-g-t-m from tomhudson@google.com
Link to the patchset: https://codereview.chromium.org/2087273002/#ps60001
(title: "Style guideline changes")

[commit-bot: I haz the power, 2016-06-22 18:45:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2087273002/60001

[commit-bot: I haz the power, 2016-06-22 18:52:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-22 18:52:34]

Try jobs failed on following builders:
  Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...)

[fmenozzi, 2016-06-22 19:21:10]

The CQ bit was checked by fmenozzi@google.com

[fmenozzi, 2016-06-22 19:21:10]

The patchset sent to the CQ was uploaded after l-g-t-m from tomhudson@google.com
Link to the patchset: https://codereview.chromium.org/2087273002/#ps80001
(title: "Fix SkScalar/override compiler warnings")

[commit-bot: I haz the power, 2016-06-22 19:21:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2087273002/80001

[commit-bot: I haz the power, 2016-06-22 20:39:30]

Description was changed from

==========
Add GM for hard stop gradients

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2087273002
==========

to

==========
Add GM for hard stop gradients

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2087273002

Committed:
https://skia.googlesource.com/skia/+/17b64b2fd4df538ec952b128a07dbf6ae0afe990
==========

[commit-bot: I haz the power, 2016-06-22 20:39:31]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/17b64b2fd4df538ec952b128a07dbf6ae0afe990