Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2087143002: [Binding] [Refactoring] Create Writer and Serializer in one method (Closed)

Created:
4 years, 6 months ago by peria
Modified:
4 years, 6 months ago
Reviewers:
haraken, Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Creates SerializedScriptWriter and ScriptValueSerializer in one method. Before this CL, Writer and Serializer are constructed separately and we did some common tasks between them, so Factory needed some overrided methods to work for them. After this CL, Writer and Serializer are constructed at once, and we can wrap common tasks in Serializer. BUG=614919 Committed: https://crrev.com/cd6cb132882322d79684d805103be3abcd38b7d4 Cr-Commit-Position: refs/heads/master@{#401253}

Patch Set 1 #

Patch Set 2 : Remove redandant create() in Factory #

Patch Set 3 : Handle v8::TryCatch in Serializer #

Patch Set 4 : Use enum class #

Patch Set 5 : Fix Debug build #

Messages

Total messages: 17 (10 generated)
peria
PTL.
4 years, 6 months ago (2016-06-22 08:41:42 UTC) #5
haraken
LGTM
4 years, 6 months ago (2016-06-22 08:53:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2087143002/80001
4 years, 6 months ago (2016-06-22 08:58:10 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_android on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/85145) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 6 months ago (2016-06-22 09:08:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2087143002/100001
4 years, 6 months ago (2016-06-22 10:25:48 UTC) #13
commit-bot: I haz the power
Committed patchset #5 (id:100001)
4 years, 6 months ago (2016-06-22 11:46:42 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 11:48:35 UTC) #17
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/cd6cb132882322d79684d805103be3abcd38b7d4
Cr-Commit-Position: refs/heads/master@{#401253}

Powered by Google App Engine
This is Rietveld 408576698