third_party/WebKit/Source/bindings/modules/v8/ScriptValueSerializerForModules.h - Issue 2087143002: [Binding] [Refactoring] Create Writer and Serializer in one method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/modules/v8/ScriptValueSerializerForModules.h

Issue 2087143002: [Binding] [Refactoring] Create Writer and Serializer in one method (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix Debug build Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/SerializedScriptValueFactory.cpp ('k') | third_party/WebKit/Source/bindings/modules/v8/ScriptValueSerializerForModules.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/modules/v8/ScriptValueSerializerForModules.h

diff --git a/third_party/WebKit/Source/bindings/modules/v8/ScriptValueSerializerForModules.h b/third_party/WebKit/Source/bindings/modules/v8/ScriptValueSerializerForModules.h

index d661459f9ef6363ef477c15c84d3461d49383ac1..496405657e3099f50f81ef6304f09aca86c4d9ff 100644

--- a/third_party/WebKit/Source/bindings/modules/v8/ScriptValueSerializerForModules.h

+++ b/third_party/WebKit/Source/bindings/modules/v8/ScriptValueSerializerForModules.h

@@ -73,7 +73,7 @@ class ScriptValueSerializerForModules final : public ScriptValueSerializer {

STACK_ALLOCATED();

WTF_MAKE_NONCOPYABLE(ScriptValueSerializerForModules);

public:

- ScriptValueSerializerForModules(SerializedScriptValueWriter&, const Transferables*, WebBlobInfoArray*, BlobDataHandleMap&, v8::TryCatch&, ScriptState*);

+ ScriptValueSerializerForModules(SerializedScriptValueWriter&, const Transferables*, WebBlobInfoArray*, ScriptState*);

private:

ScriptValueSerializer::StateBase* doSerializeObject(v8::Local<v8::Object>, ScriptValueSerializer::StateBase* next) override;