Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Unified Diff: third_party/WebKit/Source/bindings/modules/v8/ScriptValueSerializerForModules.cpp

Issue 2087143002: [Binding] [Refactoring] Create Writer and Serializer in one method (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Debug build Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/modules/v8/ScriptValueSerializerForModules.cpp
diff --git a/third_party/WebKit/Source/bindings/modules/v8/ScriptValueSerializerForModules.cpp b/third_party/WebKit/Source/bindings/modules/v8/ScriptValueSerializerForModules.cpp
index 0c6a6d58d0b190cc5d5e0db05d27c60c545e9e79..318494b1f819c300defd9cd2e099d5b66d771c72 100644
--- a/third_party/WebKit/Source/bindings/modules/v8/ScriptValueSerializerForModules.cpp
+++ b/third_party/WebKit/Source/bindings/modules/v8/ScriptValueSerializerForModules.cpp
@@ -79,8 +79,8 @@ enum AssymetricCryptoKeyType {
};
-ScriptValueSerializerForModules::ScriptValueSerializerForModules(SerializedScriptValueWriter& writer, const Transferables* transferables, WebBlobInfoArray* blobInfo, BlobDataHandleMap& blobDataHandles, v8::TryCatch& tryCatch, ScriptState* scriptState)
- : ScriptValueSerializer(writer, transferables, blobInfo, blobDataHandles, tryCatch, scriptState)
+ScriptValueSerializerForModules::ScriptValueSerializerForModules(SerializedScriptValueWriter& writer, const Transferables* transferables, WebBlobInfoArray* blobInfo, ScriptState* scriptState)
+ : ScriptValueSerializer(writer, transferables, blobInfo, scriptState)
{
}
@@ -90,7 +90,7 @@ ScriptValueSerializer::StateBase* ScriptValueSerializerForModules::writeDOMFileS
if (!fs)
return 0;
if (!fs->clonable())
- return handleError(DataCloneError, "A FileSystem object could not be cloned.", next);
+ return handleError(Status::DataCloneError, "A FileSystem object could not be cloned.", next);
toSerializedScriptValueWriterForModules(writer()).writeDOMFileSystem(fs->type(), fs->name(), fs->rootURL().getString());
return 0;
@@ -108,7 +108,7 @@ ScriptValueSerializer::StateBase* ScriptValueSerializerForModules::writeRTCCerti
{
RTCCertificate* certificate = V8RTCCertificate::toImpl(value.As<v8::Object>());
if (!certificate)
- return handleError(DataCloneError, "An RTCCertificate object could not be cloned.", next);
+ return handleError(Status::DataCloneError, "An RTCCertificate object could not be cloned.", next);
toSerializedScriptValueWriterForModules(writer()).writeRTCCertificate(*certificate);
return nullptr;
}
@@ -325,7 +325,7 @@ ScriptValueSerializer::StateBase* ScriptValueSerializerForModules::doSerializeOb
if (V8CryptoKey::hasInstance(jsObject, isolate())) {
greyObject(jsObject);
if (!writeCryptoKey(jsObject))
- return handleError(DataCloneError, "Couldn't serialize key data", next);
+ return handleError(Status::DataCloneError, "Couldn't serialize key data", next);
return nullptr;
}
if (V8RTCCertificate::hasInstance(jsObject, isolate())) {

Powered by Google App Engine
This is Rietveld 408576698