Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Unified Diff: components/offline_pages/offline_page_model_impl_unittest.cc

Issue 2086733002: [Offline Pages] Fix cases where returning NOT_FOUND when deleting. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix comments. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/offline_pages/offline_page_model_impl.cc ('k') | components/offline_pages/offline_page_types.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/offline_pages/offline_page_model_impl_unittest.cc
diff --git a/components/offline_pages/offline_page_model_impl_unittest.cc b/components/offline_pages/offline_page_model_impl_unittest.cc
index 184858c9bb7941ad440b7ce31b0edcc36bdbdb5d..cb0ee364f6a5416e3d3d9ddf46dbd0aec76feb60 100644
--- a/components/offline_pages/offline_page_model_impl_unittest.cc
+++ b/components/offline_pages/offline_page_model_impl_unittest.cc
@@ -687,14 +687,14 @@ TEST_F(OfflinePageModelImplTest, DeletePageByPredicate) {
TEST_F(OfflinePageModelImplTest, DeletePageNotFound) {
DeletePage(1234LL, base::Bind(&OfflinePageModelImplTest::OnDeletePageDone,
AsWeakPtr()));
- EXPECT_EQ(DeletePageResult::NOT_FOUND, last_delete_result());
+ EXPECT_EQ(DeletePageResult::SUCCESS, last_delete_result());
ResetResults();
model()->DeletePagesByURLPredicate(
base::Bind(&URLSpecContains, "page.com"),
base::Bind(&OfflinePageModelImplTest::OnDeletePageDone, AsWeakPtr()));
- EXPECT_EQ(DeletePageResult::NOT_FOUND, last_delete_result());
+ EXPECT_EQ(DeletePageResult::SUCCESS, last_delete_result());
}
TEST_F(OfflinePageModelImplTest, DeletePageStoreFailureOnRemove) {
« no previous file with comments | « components/offline_pages/offline_page_model_impl.cc ('k') | components/offline_pages/offline_page_types.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698