Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Side by Side Diff: components/offline_pages/offline_page_model_impl_unittest.cc

Issue 2086733002: [Offline Pages] Fix cases where returning NOT_FOUND when deleting. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix comments. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/offline_pages/offline_page_model_impl.h" 5 #include "components/offline_pages/offline_page_model_impl.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 #include <algorithm> 8 #include <algorithm>
9 #include <utility> 9 #include <utility>
10 10
(...skipping 669 matching lines...) Expand 10 before | Expand all | Expand 10 after
680 680
681 EXPECT_EQ(last_deleted_offline_id(), offline1); 681 EXPECT_EQ(last_deleted_offline_id(), offline1);
682 EXPECT_EQ(last_deleted_client_id(), kTestClientId1); 682 EXPECT_EQ(last_deleted_client_id(), kTestClientId1);
683 EXPECT_EQ(DeletePageResult::SUCCESS, last_delete_result()); 683 EXPECT_EQ(DeletePageResult::SUCCESS, last_delete_result());
684 EXPECT_EQ(0u, store->GetAllPages().size()); 684 EXPECT_EQ(0u, store->GetAllPages().size());
685 } 685 }
686 686
687 TEST_F(OfflinePageModelImplTest, DeletePageNotFound) { 687 TEST_F(OfflinePageModelImplTest, DeletePageNotFound) {
688 DeletePage(1234LL, base::Bind(&OfflinePageModelImplTest::OnDeletePageDone, 688 DeletePage(1234LL, base::Bind(&OfflinePageModelImplTest::OnDeletePageDone,
689 AsWeakPtr())); 689 AsWeakPtr()));
690 EXPECT_EQ(DeletePageResult::NOT_FOUND, last_delete_result()); 690 EXPECT_EQ(DeletePageResult::SUCCESS, last_delete_result());
691 691
692 ResetResults(); 692 ResetResults();
693 693
694 model()->DeletePagesByURLPredicate( 694 model()->DeletePagesByURLPredicate(
695 base::Bind(&URLSpecContains, "page.com"), 695 base::Bind(&URLSpecContains, "page.com"),
696 base::Bind(&OfflinePageModelImplTest::OnDeletePageDone, AsWeakPtr())); 696 base::Bind(&OfflinePageModelImplTest::OnDeletePageDone, AsWeakPtr()));
697 EXPECT_EQ(DeletePageResult::NOT_FOUND, last_delete_result()); 697 EXPECT_EQ(DeletePageResult::SUCCESS, last_delete_result());
698 } 698 }
699 699
700 TEST_F(OfflinePageModelImplTest, DeletePageStoreFailureOnRemove) { 700 TEST_F(OfflinePageModelImplTest, DeletePageStoreFailureOnRemove) {
701 // Save a page. 701 // Save a page.
702 SavePage(kTestUrl, kTestClientId1); 702 SavePage(kTestUrl, kTestClientId1);
703 int64_t offline_id = last_save_offline_id(); 703 int64_t offline_id = last_save_offline_id();
704 ResetResults(); 704 ResetResults();
705 705
706 // Try to delete this page. 706 // Try to delete this page.
707 GetStore()->set_test_scenario( 707 GetStore()->set_test_scenario(
(...skipping 363 matching lines...) Expand 10 before | Expand all | Expand 10 after
1071 std::unique_ptr<base::FeatureList> feature_list2(new base::FeatureList); 1071 std::unique_ptr<base::FeatureList> feature_list2(new base::FeatureList);
1072 feature_list2->InitializeFromCommandLine( 1072 feature_list2->InitializeFromCommandLine(
1073 std::string(offline_pages::kOfflineBookmarksFeature.name) + "," + 1073 std::string(offline_pages::kOfflineBookmarksFeature.name) + "," +
1074 offline_pages::kOfflinePagesBackgroundLoadingFeature.name, 1074 offline_pages::kOfflinePagesBackgroundLoadingFeature.name,
1075 ""); 1075 "");
1076 base::FeatureList::SetInstance(std::move(feature_list2)); 1076 base::FeatureList::SetInstance(std::move(feature_list2));
1077 EXPECT_TRUE(offline_pages::IsOfflinePagesBackgroundLoadingEnabled()); 1077 EXPECT_TRUE(offline_pages::IsOfflinePagesBackgroundLoadingEnabled());
1078 } 1078 }
1079 1079
1080 } // namespace offline_pages 1080 } // namespace offline_pages
OLDNEW
« no previous file with comments | « components/offline_pages/offline_page_model_impl.cc ('k') | components/offline_pages/offline_page_types.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698