components/offline_pages/offline_page_types.h - Issue 2086733002: [Offline Pages] Fix cases where returning NOT_FOUND when deleting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/offline_page_types.h

Issue 2086733002: [Offline Pages] Fix cases where returning NOT_FOUND when deleting. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/offline_pages/offline_page_types.h

diff --git a/components/offline_pages/offline_page_types.h b/components/offline_pages/offline_page_types.h

index 27e9fe98b6fe3ace7c496c4c7e0c7fc2b28c2384..20d0d99837104db7f3a06d704c64b996f247620c 100644

--- a/components/offline_pages/offline_page_types.h

+++ b/components/offline_pages/offline_page_types.h

@@ -48,6 +48,8 @@ enum class DeletePageResult {

CANCELLED,

STORE_FAILURE,

DEVICE_FAILURE,

+ // Deprecated. Deleting pages which are not in metadata store would be

+ // returing |SUCCESS|. Should not be used anymore.

NOT_FOUND,

// NOTE: always keep this entry at the end. Add new result types only

// immediately above this line. Make sure to update the corresponding

« no previous file with comments | « components/offline_pages/offline_page_model_impl_unittest.cc ('k') | no next file » | no next file with comments »