Don't sync browser.show_home_button and homepage_is_newtabpage to mobile platforms.

Don't sync browser.show_home_button and homepage_is_newtabpageto mobile platforms.

Chrome will start sync prefs on mobile. For browser.show_home_button it and for homepage_is_newtabpage it is not desired.

BUG=622620
Committed: https://crrev.com/336b04cf3eab38e8663988ff2f2286a57e3d341b
Cr-Commit-Position: refs/heads/master@{#402436}

[melandory, 2016-06-23 12:03:16]

PTAL, thanks

[melandory, 2016-06-23 12:03:47]

melandory@chromium.org changed reviewers:
+ sky@chromium.org

[melandory, 2016-06-23 12:03:48]

PTAL, thanks

[sky, 2016-06-23 15:49:33]

https://codereview.chromium.org/2086143004/diff/1/chrome/browser/ui/browser_u...
File chrome/browser/ui/browser_ui_prefs.cc (right):

https://codereview.chromium.org/2086143004/diff/1/chrome/browser/ui/browser_u...
chrome/browser/ui/browser_ui_prefs.cc:37: uint32_t flags =
PrefRegistry::NO_REGISTRATION_FLAGS;
nit: please use a better name than flags, perhaps home_button_flags. Another
option is to move this to a function and change line 44 to GetHomeButtonFlags().

[melandory, 2016-06-25 00:46:32]

Description was changed from

==========
Don't sync browser.show_home_button pref to mobile platforms.

Chrome will start sync prefs on mobile. For browser.show_home_button it
is not desired.

BUG=622620
==========

to

==========
Don't sync browser.show_home_button and homepage_is_newtabpageto mobile
platforms.

Chrome will start sync prefs on mobile. For browser.show_home_button it and for
homepage_is_newtabpage it is not desired.

BUG=622620
==========

[melandory, 2016-06-25 00:46:42]

Patchset #3 (id:40001) has been deleted

[melandory, 2016-06-25 01:24:50]

https://codereview.chromium.org/2086143004/diff/1/chrome/browser/ui/browser_u...
File chrome/browser/ui/browser_ui_prefs.cc (right):

https://codereview.chromium.org/2086143004/diff/1/chrome/browser/ui/browser_u...
chrome/browser/ui/browser_ui_prefs.cc:37: uint32_t flags =
PrefRegistry::NO_REGISTRATION_FLAGS;
On 2016/06/23 15:49:33, sky wrote:
> nit: please use a better name than flags, perhaps home_button_flags. Another
> option is to move this to a function and change line 44 to
GetHomeButtonFlags().

Done.

[sky, 2016-06-27 15:10:15]

LGTM

[melandory, 2016-06-28 08:01:13]

The CQ bit was checked by melandory@chromium.org

[commit-bot: I haz the power, 2016-06-28 08:01:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 08:28:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-28 08:28:48]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[melandory, 2016-06-28 09:37:09]

The CQ bit was checked by melandory@chromium.org

[commit-bot: I haz the power, 2016-06-28 09:37:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 10:05:21]

Description was changed from

==========
Don't sync browser.show_home_button and homepage_is_newtabpageto mobile
platforms.

Chrome will start sync prefs on mobile. For browser.show_home_button it and for
homepage_is_newtabpage it is not desired.

BUG=622620
==========

to

==========
Don't sync browser.show_home_button and homepage_is_newtabpageto mobile
platforms.

Chrome will start sync prefs on mobile. For browser.show_home_button it and for
homepage_is_newtabpage it is not desired.

BUG=622620
==========

[commit-bot: I haz the power, 2016-06-28 10:05:22]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-06-28 10:06:53]

Description was changed from

==========
Don't sync browser.show_home_button and homepage_is_newtabpageto mobile
platforms.

Chrome will start sync prefs on mobile. For browser.show_home_button it and for
homepage_is_newtabpage it is not desired.

BUG=622620
==========

to

==========
Don't sync browser.show_home_button and homepage_is_newtabpageto mobile
platforms.

Chrome will start sync prefs on mobile. For browser.show_home_button it and for
homepage_is_newtabpage it is not desired.

BUG=622620

Committed: https://crrev.com/336b04cf3eab38e8663988ff2f2286a57e3d341b
Cr-Commit-Position: refs/heads/master@{#402436}
==========

[commit-bot: I haz the power, 2016-06-28 10:06:54]

Patchset 3 (id:??) landed as
https://crrev.com/336b04cf3eab38e8663988ff2f2286a57e3d341b
Cr-Commit-Position: refs/heads/master@{#402436}