Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Side by Side Diff: chrome/browser/ui/browser_ui_prefs.cc

Issue 2086143004: Don't sync browser.show_home_button and homepage_is_newtabpage to mobile platforms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/browser_ui_prefs.h" 5 #include "chrome/browser/ui/browser_ui_prefs.h"
6 6
7 #include "build/build_config.h" 7 #include "build/build_config.h"
8 #include "chrome/browser/first_run/first_run.h" 8 #include "chrome/browser/first_run/first_run.h"
9 #include "chrome/browser/profiles/profile.h" 9 #include "chrome/browser/profiles/profile.h"
10 #include "chrome/common/pref_names.h" 10 #include "chrome/common/pref_names.h"
(...skipping 15 matching lines...) Expand all
26 registry->RegisterBooleanPref(prefs::kAllowFileSelectionDialogs, true); 26 registry->RegisterBooleanPref(prefs::kAllowFileSelectionDialogs, true);
27 registry->RegisterIntegerPref(prefs::kShowFirstRunBubbleOption, 27 registry->RegisterIntegerPref(prefs::kShowFirstRunBubbleOption,
28 first_run::FIRST_RUN_BUBBLE_DONT_SHOW); 28 first_run::FIRST_RUN_BUBBLE_DONT_SHOW);
29 } 29 }
30 30
31 void RegisterBrowserUserPrefs(user_prefs::PrefRegistrySyncable* registry) { 31 void RegisterBrowserUserPrefs(user_prefs::PrefRegistrySyncable* registry) {
32 registry->RegisterBooleanPref( 32 registry->RegisterBooleanPref(
33 prefs::kHomePageIsNewTabPage, 33 prefs::kHomePageIsNewTabPage,
34 true, 34 true,
35 user_prefs::PrefRegistrySyncable::SYNCABLE_PREF); 35 user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
36 #if defined(OS_IOS) || defined(OS_ANDROID)
37 uint32_t flags = PrefRegistry::NO_REGISTRATION_FLAGS;
sky 2016/06/23 15:49:33 nit: please use a better name than flags, perhaps
melandory 2016/06/25 01:24:50 Done.
38 #else
39 uint32_t flags = user_prefs::PrefRegistrySyncable::SYNCABLE_PREF;
40 #endif
36 registry->RegisterBooleanPref( 41 registry->RegisterBooleanPref(
37 prefs::kShowHomeButton, 42 prefs::kShowHomeButton,
38 false, 43 false,
39 user_prefs::PrefRegistrySyncable::SYNCABLE_PREF); 44 flags);
40 registry->RegisterBooleanPref( 45 registry->RegisterBooleanPref(
41 prefs::kDeleteBrowsingHistory, 46 prefs::kDeleteBrowsingHistory,
42 true, 47 true,
43 user_prefs::PrefRegistrySyncable::SYNCABLE_PREF); 48 user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
44 registry->RegisterBooleanPref( 49 registry->RegisterBooleanPref(
45 prefs::kDeleteDownloadHistory, 50 prefs::kDeleteDownloadHistory,
46 true, 51 true,
47 user_prefs::PrefRegistrySyncable::SYNCABLE_PREF); 52 user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
48 registry->RegisterBooleanPref( 53 registry->RegisterBooleanPref(
49 prefs::kDeleteCache, 54 prefs::kDeleteCache,
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
143 registry->RegisterBooleanPref( 148 registry->RegisterBooleanPref(
144 prefs::kHideFullscreenToolbar, 149 prefs::kHideFullscreenToolbar,
145 false, 150 false,
146 user_prefs::PrefRegistrySyncable::SYNCABLE_PREF); 151 user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
147 #else 152 #else
148 registry->RegisterBooleanPref(prefs::kFullscreenAllowed, true); 153 registry->RegisterBooleanPref(prefs::kFullscreenAllowed, true);
149 #endif 154 #endif
150 } 155 }
151 156
152 } // namespace chrome 157 } // namespace chrome
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698