Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Side by Side Diff: chrome/browser/ui/browser_ui_prefs.cc

Issue 2086143004: Don't sync browser.show_home_button and homepage_is_newtabpage to mobile platforms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: make homepage_is_newtabpage also unsyncable on mobile Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/browser_ui_prefs.h" 5 #include "chrome/browser/ui/browser_ui_prefs.h"
6 6
7 #include "build/build_config.h" 7 #include "build/build_config.h"
8 #include "chrome/browser/first_run/first_run.h" 8 #include "chrome/browser/first_run/first_run.h"
9 #include "chrome/browser/profiles/profile.h" 9 #include "chrome/browser/profiles/profile.h"
10 #include "chrome/common/pref_names.h" 10 #include "chrome/common/pref_names.h"
11 #include "components/pref_registry/pref_registry_syncable.h" 11 #include "components/pref_registry/pref_registry_syncable.h"
12 #include "components/prefs/pref_registry_simple.h" 12 #include "components/prefs/pref_registry_simple.h"
13 #include "components/prefs/pref_service.h" 13 #include "components/prefs/pref_service.h"
14 #include "components/prefs/scoped_user_pref_update.h" 14 #include "components/prefs/scoped_user_pref_update.h"
15 #include "components/translate/core/common/translate_pref_names.h" 15 #include "components/translate/core/common/translate_pref_names.h"
16 #include "content/public/common/webrtc_ip_handling_policy.h" 16 #include "content/public/common/webrtc_ip_handling_policy.h"
17 17
18 #if defined(OS_WIN) 18 #if defined(OS_WIN)
19 #include "base/win/windows_version.h" 19 #include "base/win/windows_version.h"
20 #endif 20 #endif
21 21
22 namespace {
23
24 uint32_t GetHomeButtonAndHomePageIsNewTabPageFlags() {
25 #if defined(OS_IOS) || defined(OS_ANDROID)
26 return PrefRegistry::NO_REGISTRATION_FLAGS;
27 #else
28 return user_prefs::PrefRegistrySyncable::SYNCABLE_PREF;
29 #endif
30 }
31
32 } // namespace
33
22 namespace chrome { 34 namespace chrome {
23 35
24 void RegisterBrowserPrefs(PrefRegistrySimple* registry) { 36 void RegisterBrowserPrefs(PrefRegistrySimple* registry) {
25 registry->RegisterIntegerPref(prefs::kOptionsWindowLastTabIndex, 0); 37 registry->RegisterIntegerPref(prefs::kOptionsWindowLastTabIndex, 0);
26 registry->RegisterBooleanPref(prefs::kAllowFileSelectionDialogs, true); 38 registry->RegisterBooleanPref(prefs::kAllowFileSelectionDialogs, true);
27 registry->RegisterIntegerPref(prefs::kShowFirstRunBubbleOption, 39 registry->RegisterIntegerPref(prefs::kShowFirstRunBubbleOption,
28 first_run::FIRST_RUN_BUBBLE_DONT_SHOW); 40 first_run::FIRST_RUN_BUBBLE_DONT_SHOW);
29 } 41 }
30 42
31 void RegisterBrowserUserPrefs(user_prefs::PrefRegistrySyncable* registry) { 43 void RegisterBrowserUserPrefs(user_prefs::PrefRegistrySyncable* registry) {
32 registry->RegisterBooleanPref( 44 registry->RegisterBooleanPref(
33 prefs::kHomePageIsNewTabPage, 45 prefs::kHomePageIsNewTabPage,
34 true, 46 true,
35 user_prefs::PrefRegistrySyncable::SYNCABLE_PREF); 47 GetHomeButtonAndHomePageIsNewTabPageFlags());
36 registry->RegisterBooleanPref( 48 registry->RegisterBooleanPref(prefs::kShowHomeButton, false,
37 prefs::kShowHomeButton, 49 GetHomeButtonAndHomePageIsNewTabPageFlags());
38 false,
39 user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
40 registry->RegisterBooleanPref( 50 registry->RegisterBooleanPref(
41 prefs::kDeleteBrowsingHistory, 51 prefs::kDeleteBrowsingHistory,
42 true, 52 true,
43 user_prefs::PrefRegistrySyncable::SYNCABLE_PREF); 53 user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
44 registry->RegisterBooleanPref( 54 registry->RegisterBooleanPref(
45 prefs::kDeleteDownloadHistory, 55 prefs::kDeleteDownloadHistory,
46 true, 56 true,
47 user_prefs::PrefRegistrySyncable::SYNCABLE_PREF); 57 user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
48 registry->RegisterBooleanPref( 58 registry->RegisterBooleanPref(
49 prefs::kDeleteCache, 59 prefs::kDeleteCache,
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
143 registry->RegisterBooleanPref( 153 registry->RegisterBooleanPref(
144 prefs::kHideFullscreenToolbar, 154 prefs::kHideFullscreenToolbar,
145 false, 155 false,
146 user_prefs::PrefRegistrySyncable::SYNCABLE_PREF); 156 user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
147 #else 157 #else
148 registry->RegisterBooleanPref(prefs::kFullscreenAllowed, true); 158 registry->RegisterBooleanPref(prefs::kFullscreenAllowed, true);
149 #endif 159 #endif
150 } 160 }
151 161
152 } // namespace chrome 162 } // namespace chrome
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698