Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 2086013003: Make sure to lazyReattach a distributed node if it is already attached (Closed)

Created:
4 years, 6 months ago by hayato
Modified:
4 years, 6 months ago
Reviewers:
tkent, kochi
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof, webcomponents-bugzilla_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make sure to lazyReattach a distributed node if it is already attached For Shadow DOM v0, InsertionPoint::setDistributedNodes() is calling lazyReattachIfAttached for distributed nodes, if necessary. The same thing should be done for Shadow DOM v1 too. Unless that, the old layout object will be re-used wrongly. BUG=531990, 622185 Committed: https://crrev.com/505c030552ed7a13a108f77ce0829409e542b07c Cr-Commit-Position: refs/heads/master@{#401512}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -5 lines) Patch
A third_party/WebKit/LayoutTests/shadow-dom/layout.html View 1 chunk +17 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/shadow-dom/layout-expected.html View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSlotElement.h View 3 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSlotElement.cpp View 3 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2086013003/1
4 years, 6 months ago (2016-06-22 10:28:53 UTC) #2
hayato
PTAL. As I and kochi@ chatted offline, this is another approach of https://codereview.chromium.org/2085853004, to avoid ...
4 years, 6 months ago (2016-06-22 10:41:38 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-22 11:40:42 UTC) #10
kochi
LGTM Let's think more about optimization later.
4 years, 6 months ago (2016-06-23 01:10:31 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2086013003/1
4 years, 6 months ago (2016-06-23 01:44:28 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-23 01:49:41 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 01:53:11 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/505c030552ed7a13a108f77ce0829409e542b07c
Cr-Commit-Position: refs/heads/master@{#401512}

Powered by Google App Engine
This is Rietveld 408576698