Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 2085853004: Force reattach all shadow host's children (Closed)

Created:
4 years, 6 months ago by kochi
Modified:
4 years, 6 months ago
Reviewers:
hayato
CC:
chromium-reviews, webcomponents-bugzilla_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Force reattach all shadow host's children When an element is slotted to some slot in shadow root, its style/layout was not recalculated if the layout was up-to-date when assignment happens. At slot assignment, only non-slotted nodes were detached, but it is also necessary for those slotted. BUG=622185

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -11 lines) Patch
A third_party/WebKit/LayoutTests/shadow-dom/layout-update-on-slotassignment.html View 1 chunk +24 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp View 1 chunk +3 lines, -11 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
kochi
This is a pre-requisite for https://codereview.chromium.org/2051703002/ (offsetParent) to pass the test.
4 years, 6 months ago (2016-06-22 06:04:54 UTC) #2
kochi
On 2016/06/22 06:04:54, kochi wrote: > This is a pre-requisite for https://codereview.chromium.org/2051703002/ > (offsetParent) > ...
4 years, 6 months ago (2016-06-22 06:05:33 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2085853004/1
4 years, 6 months ago (2016-06-22 06:05:53 UTC) #5
hayato
I will take a look. Do you know what is the difference v0 and v1 ...
4 years, 6 months ago (2016-06-22 06:38:02 UTC) #6
kochi
On 2016/06/22 06:38:02, hayato wrote: > I will take a look. > > Do you ...
4 years, 6 months ago (2016-06-22 06:57:19 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-22 07:13:54 UTC) #9
hayato
I mean where v0 deattaches it for distributed nodes?
4 years, 6 months ago (2016-06-22 07:14:49 UTC) #10
kochi
4 years, 6 months ago (2016-06-23 02:04:49 UTC) #11
Message was sent while issue was closed.
closing this as https://codereview.chromium.org/2086013003/ superseded this.

Powered by Google App Engine
This is Rietveld 408576698