third_party/WebKit/Source/core/html/HTMLSlotElement.h - Issue 2086013003: Make sure to lazyReattach a distributed node if it is already attached

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLSlotElement.h

Issue 2086013003: Make sure to lazyReattach a distributed node if it is already attached (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp ('k') | third_party/WebKit/Source/core/html/HTMLSlotElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLSlotElement.h

diff --git a/third_party/WebKit/Source/core/html/HTMLSlotElement.h b/third_party/WebKit/Source/core/html/HTMLSlotElement.h

index 9721bdaa5043171ccd25bd9b3d2ce9560fd8eaea..bf36612cb38d3211b4fb332ced1f86e90bd5f716 100644

--- a/third_party/WebKit/Source/core/html/HTMLSlotElement.h

+++ b/third_party/WebKit/Source/core/html/HTMLSlotElement.h

@@ -61,6 +61,8 @@ public:

void updateDistributedNodesWithFallback();

+ void lazyReattachDistributedNodesIfNeeded();

void attach(const AttachContext& = AttachContext()) final;

void detach(const AttachContext& = AttachContext()) final;

@@ -78,6 +80,7 @@ public:

void enqueueSlotChangeEvent();

void clearDistribution();

+ void saveAndClearDistribution();

static AtomicString normalizeSlotName(const AtomicString&);

@@ -94,6 +97,7 @@ private:

HeapVector<Member<Node>> m_assignedNodes;

HeapVector<Member<Node>> m_distributedNodes;

+ HeapVector<Member<Node>> m_oldDistributedNodes;

HeapHashMap<Member<const Node>, size_t> m_distributedIndices;

bool m_slotchangeEventEnqueued = false;

};