Limit the background trials upload size to 100Kib when using mobile data

Limit the background trials upload size to 100Kib when using mobile data

The crash data is uploaded only if the file size was less than 10MB.
But, this does not consider if device is running on wifi or mobile data.
Uploading 10Mib crash files over data will be undesireable for android
and ios users. To fix this issue, the limit is set to 100Kib if the
connection is over data or connection type is unknown when tracing is
running for background field trials.

BUG=622047
Committed: https://crrev.com/f7de02da8220c2d43301d41ee232002e79d87218
Cr-Commit-Position: refs/heads/master@{#401644}

[ssid, 2016-06-21 16:23:50]

ssid@chromium.org changed reviewers:
+ oysteine@chromium.org

[ssid, 2016-06-21 16:23:51]

Does this change make sense?

[oystein (OOO til 10th of July), 2016-06-21 19:08:04]

On 2016/06/21 16:23:51, ssid wrote:
> Does this change make sense?

I think this is awesome for Bulk Reports users, I just don't think we'd
necessarily want it for deep reports users. Maybe it could be configurable by
caller, like the trace upload URL is? That way we could constrain it in the same
way we constrain the PII whitelisting i.e. only when the config is set from
field-trials i.e. bulk reports.

[ssid, 2016-06-21 21:06:57]

Description was changed from

==========
Limit the crash uploader file size to 100Kib when using mobile data

The crash data is uploaded only if the file size was less than 10MB.
But, this does not consider if device is running on wifi or mobile data.
Uploading 10Mib crash files over data will be undesireable for a low-end
android user. To fix this issue, the limit is set to 100Kib if the
connection is over data or connection type is unknown.

BUG=
==========

to

==========
Limit the crash uploader file size to 100Kib when using mobile data

The crash data is uploaded only if the file size was less than 10MB.
But, this does not consider if device is running on wifi or mobile data.
Uploading 10Mib crash files over data will be undesireable for a low-end
android user. To fix this issue, the limit is set to 100Kib if the
connection is over data or connection type is unknown.

BUG=622047
==========

[ssid, 2016-06-22 21:39:38]

Description was changed from

==========
Limit the crash uploader file size to 100Kib when using mobile data

The crash data is uploaded only if the file size was less than 10MB.
But, this does not consider if device is running on wifi or mobile data.
Uploading 10Mib crash files over data will be undesireable for a low-end
android user. To fix this issue, the limit is set to 100Kib if the
connection is over data or connection type is unknown.

BUG=622047
==========

to

==========
Limit the background trials upload size to 100Kib when using mobile data

The crash data is uploaded only if the file size was less than 10MB.
But, this does not consider if device is running on wifi or mobile data.
Uploading 10Mib crash files over data will be undesireable for android
and ios users. To fix this issue, the limit is set to 100Kib if the
connection is over data or connection type is unknown when tracing is
running for background field trials.

BUG=622047
==========

[ssid, 2016-06-22 21:42:04]

Patchset #2 (id:20001) has been deleted

[ssid, 2016-06-22 21:46:51]

> I think this is awesome for Bulk Reports users, I just don't think we'd
> necessarily want it for deep reports users. Maybe it could be configurable by
> caller, like the trace upload URL is? That way we could constrain it in the
same
> way we constrain the PII whitelisting i.e. only when the config is set from
> field-trials i.e. bulk reports.

Changed as you suggested. PTAl, thanks.

[oystein (OOO til 10th of July), 2016-06-23 08:38:35]

Awesome, thank you!

lgtm!

[ssid, 2016-06-23 16:30:58]

The CQ bit was checked by ssid@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-23 16:31:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2085623005/40001

[commit-bot: I haz the power, 2016-06-23 17:21:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-23 17:21:10]

Dry run: This issue passed the CQ dry run.

[ssid, 2016-06-23 17:25:40]

The CQ bit was checked by ssid@chromium.org

[commit-bot: I haz the power, 2016-06-23 17:25:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2085623005/40001

[commit-bot: I haz the power, 2016-06-23 17:29:33]

Description was changed from

==========
Limit the background trials upload size to 100Kib when using mobile data

The crash data is uploaded only if the file size was less than 10MB.
But, this does not consider if device is running on wifi or mobile data.
Uploading 10Mib crash files over data will be undesireable for android
and ios users. To fix this issue, the limit is set to 100Kib if the
connection is over data or connection type is unknown when tracing is
running for background field trials.

BUG=622047
==========

to

==========
Limit the background trials upload size to 100Kib when using mobile data

The crash data is uploaded only if the file size was less than 10MB.
But, this does not consider if device is running on wifi or mobile data.
Uploading 10Mib crash files over data will be undesireable for android
and ios users. To fix this issue, the limit is set to 100Kib if the
connection is over data or connection type is unknown when tracing is
running for background field trials.

BUG=622047
==========

[commit-bot: I haz the power, 2016-06-23 17:29:34]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-06-23 17:42:06]

Description was changed from

==========
Limit the background trials upload size to 100Kib when using mobile data

The crash data is uploaded only if the file size was less than 10MB.
But, this does not consider if device is running on wifi or mobile data.
Uploading 10Mib crash files over data will be undesireable for android
and ios users. To fix this issue, the limit is set to 100Kib if the
connection is over data or connection type is unknown when tracing is
running for background field trials.

BUG=622047
==========

to

==========
Limit the background trials upload size to 100Kib when using mobile data

The crash data is uploaded only if the file size was less than 10MB.
But, this does not consider if device is running on wifi or mobile data.
Uploading 10Mib crash files over data will be undesireable for android
and ios users. To fix this issue, the limit is set to 100Kib if the
connection is over data or connection type is unknown when tracing is
running for background field trials.

BUG=622047

Committed: https://crrev.com/f7de02da8220c2d43301d41ee232002e79d87218
Cr-Commit-Position: refs/heads/master@{#401644}
==========

[commit-bot: I haz the power, 2016-06-23 17:42:07]

Patchset 2 (id:??) landed as
https://crrev.com/f7de02da8220c2d43301d41ee232002e79d87218
Cr-Commit-Position: refs/heads/master@{#401644}