Limit the background trials upload size to 100Kib when using mobile data

chrome/browser/tracing/crash_service_uploader.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/tracing/crash_service_uploader.h"
 
 #include <utility>
 
 #include "base/command_line.h"
 #include "base/files/file_path.h"
@@ skipping 25 matching lines @@
 
 namespace {
 
 const char kUploadURL[] = "https://clients2.google.com/cr/report";
 const char kUploadContentType[] = "multipart/form-data";
 const char kMultipartBoundary[] =
     "----**--yradnuoBgoLtrapitluMklaTelgooG--**----";
 const int kHttpResponseOk = 200;
 
 // Allow up to 10MB for trace upload
-const int kMaxUploadBytes = 10000000;
+const size_t kMaxUploadBytes = 10000000;
 
 }  // namespace
 
 TraceCrashServiceUploader::TraceCrashServiceUploader(
     net::URLRequestContextGetter* request_context)
-    : request_context_(request_context) {
+    : request_context_(request_context), max_upload_bytes_(kMaxUploadBytes) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
   const base::CommandLine& command_line =
       *base::CommandLine::ForCurrentProcess();
   std::string upload_url = kUploadURL;
   if (command_line.HasSwitch(switches::kTraceUploadURL)) {
     upload_url = command_line.GetSwitchValueASCII(switches::kTraceUploadURL);
   }
   SetUploadURL(upload_url);
 }
 
 TraceCrashServiceUploader::~TraceCrashServiceUploader() {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
 }
 
 void TraceCrashServiceUploader::SetUploadURL(const std::string& url) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
   upload_url_ = url;
 
   if (!GURL(upload_url_).is_valid())
     upload_url_.clear();
 }
 
+void TraceCrashServiceUploader::SetMaxUploadBytes(size_t max_upload_bytes) {
+  DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
+  max_upload_bytes_ = max_upload_bytes;
+}
+
 void TraceCrashServiceUploader::OnURLFetchComplete(
     const net::URLFetcher* source) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
   DCHECK_EQ(source, url_fetcher_.get());
   int response_code = source->GetResponseCode();
   string feedback;
   bool success = (response_code == kHttpResponseOk);
   if (success) {
     source->GetResponseAsString(&feedback);
   } else {
@@ skipping 82 matching lines @@
     version = "unknown";
   }
 
   if (url_fetcher_.get()) {
     OnUploadError("Already uploading.");
     return;
   }
 
   std::string compressed_contents;
   if (upload_mode == COMPRESSED_UPLOAD) {
-    std::unique_ptr<char[]> compressed_buffer(new char[kMaxUploadBytes]);
+    std::unique_ptr<char[]> compressed_buffer(new char[max_upload_bytes_]);
     int compressed_bytes;
-    if (!Compress(file_contents, kMaxUploadBytes, compressed_buffer.get(),
+    if (!Compress(file_contents, max_upload_bytes_, compressed_buffer.get(),
                   &compressed_bytes)) {
       OnUploadError("Compressing file failed.");
       return;
     }
     compressed_contents =
         std::string(compressed_buffer.get(), compressed_bytes);
   } else {
-    if (file_contents.size() >= kMaxUploadBytes) {
-      OnUploadError("File is too large to upload.");
-      return;
-    }
     compressed_contents = file_contents;
   }
+  if (compressed_contents.size() > max_upload_bytes_) {
+    OnUploadError("File is too large to upload.");
+    return;
+  }
 
   std::string post_data;
   SetupMultipart(product, version, std::move(metadata), "trace.json.gz",
                  compressed_contents, &post_data);
 
   content::BrowserThread::PostTask(
       content::BrowserThread::UI, FROM_HERE,
       base::Bind(&TraceCrashServiceUploader::CreateAndStartURLFetcher,
                  base::Unretained(this), upload_url, post_data));
 }
@@ skipping 99 matching lines @@
   std::string content_type = kUploadContentType;
   content_type.append("; boundary=");
   content_type.append(kMultipartBoundary);
 
   url_fetcher_ =
       net::URLFetcher::Create(GURL(upload_url), net::URLFetcher::POST, this);
   url_fetcher_->SetRequestContext(request_context_);
   url_fetcher_->SetUploadData(content_type, post_data);
   url_fetcher_->Start();
 }