Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Side by Side Diff: chrome/browser/tracing/background_tracing_field_trial.cc

Issue 2085623005: Limit the background trials upload size to 100Kib when using mobile data (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Configure size limit. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/tracing/crash_service_uploader.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/tracing/background_tracing_field_trial.h" 5 #include "chrome/browser/tracing/background_tracing_field_trial.h"
6 6
7 #include <string> 7 #include <string>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/json/json_reader.h" 10 #include "base/json/json_reader.h"
11 #include "base/metrics/field_trial.h" 11 #include "base/metrics/field_trial.h"
12 #include "build/build_config.h"
12 #include "chrome/browser/browser_process.h" 13 #include "chrome/browser/browser_process.h"
13 #include "chrome/browser/tracing/crash_service_uploader.h" 14 #include "chrome/browser/tracing/crash_service_uploader.h"
14 #include "chrome/common/variations/variations_util.h" 15 #include "chrome/common/variations/variations_util.h"
15 #include "components/variations/variations_associated_data.h" 16 #include "components/variations/variations_associated_data.h"
16 #include "content/public/browser/background_tracing_config.h" 17 #include "content/public/browser/background_tracing_config.h"
17 #include "content/public/browser/background_tracing_manager.h" 18 #include "content/public/browser/background_tracing_manager.h"
18 #include "content/public/browser/browser_thread.h" 19 #include "content/public/browser/browser_thread.h"
20 #include "net/base/network_change_notifier.h"
19 #include "url/gurl.h" 21 #include "url/gurl.h"
20 22
21 namespace tracing { 23 namespace tracing {
22 24
23 namespace { 25 namespace {
24 26
25 const char kBackgroundTracingFieldTrial[] = "BackgroundTracing"; 27 const char kBackgroundTracingFieldTrial[] = "BackgroundTracing";
26 const char kBackgroundTracingConfig[] = "config"; 28 const char kBackgroundTracingConfig[] = "config";
27 const char kBackgroundTracingUploadUrl[] = "upload_url"; 29 const char kBackgroundTracingUploadUrl[] = "upload_url";
28 30
(...skipping 10 matching lines...) Expand all
39 void UploadCallback(const std::string& upload_url, 41 void UploadCallback(const std::string& upload_url,
40 const scoped_refptr<base::RefCountedString>& file_contents, 42 const scoped_refptr<base::RefCountedString>& file_contents,
41 std::unique_ptr<const base::DictionaryValue> metadata, 43 std::unique_ptr<const base::DictionaryValue> metadata,
42 base::Closure callback) { 44 base::Closure callback) {
43 TraceCrashServiceUploader* uploader = new TraceCrashServiceUploader( 45 TraceCrashServiceUploader* uploader = new TraceCrashServiceUploader(
44 g_browser_process->system_request_context()); 46 g_browser_process->system_request_context());
45 47
46 if (GURL(upload_url).is_valid()) 48 if (GURL(upload_url).is_valid())
47 uploader->SetUploadURL(upload_url); 49 uploader->SetUploadURL(upload_url);
48 50
51 #if defined(OS_ANDROID) || defined(OS_IOS)
52 auto connection_type = net::NetworkChangeNotifier::GetConnectionType();
53 if (connection_type != net::NetworkChangeNotifier::CONNECTION_WIFI &&
54 connection_type != net::NetworkChangeNotifier::CONNECTION_ETHERNET &&
55 connection_type != net::NetworkChangeNotifier::CONNECTION_BLUETOOTH) {
56 // Allow only 100KiB for uploads over data.
57 uploader->SetMaxUploadBytes(100 * 1024);
58 }
59 #endif // defined(OS_ANDROID) || defined(OS_IOS)
60
49 uploader->DoUpload( 61 uploader->DoUpload(
50 file_contents->data(), content::TraceUploader::UNCOMPRESSED_UPLOAD, 62 file_contents->data(), content::TraceUploader::UNCOMPRESSED_UPLOAD,
51 std::move(metadata), content::TraceUploader::UploadProgressCallback(), 63 std::move(metadata), content::TraceUploader::UploadProgressCallback(),
52 base::Bind(&OnUploadComplete, base::Owned(uploader), callback)); 64 base::Bind(&OnUploadComplete, base::Owned(uploader), callback));
53 } 65 }
54 66
55 } // namespace 67 } // namespace
56 68
57 void SetConfigTextFilterForTesting(ConfigTextFilterForTesting predicate) { 69 void SetConfigTextFilterForTesting(ConfigTextFilterForTesting predicate) {
58 g_config_text_filter_for_testing = predicate; 70 g_config_text_filter_for_testing = predicate;
(...skipping 23 matching lines...) Expand all
82 content::BackgroundTracingConfig::FromDict(dict); 94 content::BackgroundTracingConfig::FromDict(dict);
83 if (!config) 95 if (!config)
84 return; 96 return;
85 97
86 content::BackgroundTracingManager::GetInstance()->SetActiveScenario( 98 content::BackgroundTracingManager::GetInstance()->SetActiveScenario(
87 std::move(config), base::Bind(&UploadCallback, upload_url), 99 std::move(config), base::Bind(&UploadCallback, upload_url),
88 content::BackgroundTracingManager::ANONYMIZE_DATA); 100 content::BackgroundTracingManager::ANONYMIZE_DATA);
89 } 101 }
90 102
91 } // namespace tracing 103 } // namespace tracing
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/tracing/crash_service_uploader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698