Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Side by Side Diff: lib/kernel_visitor.dart

Issue 2085613002: Constant get and invoke are never called. (Closed) Base URL: git@github.com:dart-lang/rasta.git@enum
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | test/kernel/regression/constant_get_and_invoke.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE.md file. 3 // BSD-style license that can be found in the LICENSE.md file.
4 4
5 library rasta.kernel_visitor; 5 library rasta.kernel_visitor;
6 6
7 import 'package:kernel/ast.dart' as ir; 7 import 'package:kernel/ast.dart' as ir;
8 8
9 import 'package:kernel/accessors.dart' show 9 import 'package:kernel/accessors.dart' show
10 Accessor, 10 Accessor,
(...skipping 1230 matching lines...) Expand 10 before | Expand all | Expand 10 after
1241 1241
1242 @override 1242 @override
1243 ir.Expression visitConstConstructorInvoke( 1243 ir.Expression visitConstConstructorInvoke(
1244 NewExpression node, 1244 NewExpression node,
1245 ConstructedConstantExpression constant, 1245 ConstructedConstantExpression constant,
1246 _) { 1246 _) {
1247 return buildConstConstructorInvoke(node); 1247 return buildConstConstructorInvoke(node);
1248 } 1248 }
1249 1249
1250 @override 1250 @override
1251 ir.Throw visitConstantGet(Send node, ConstantExpression constant, _) { 1251 visitConstantGet(Send node, ConstantExpression constant, _) {
1252 return buildUnsupported(node, "ConstantGet"); 1252 // TODO(ahe): This method is never called. Is it a bug in semantic visitor?
1253 return internalError(node, "ConstantGet");
1253 } 1254 }
1254 1255
1255 @override 1256 @override
1256 ir.Throw visitConstantInvoke( 1257 visitConstantInvoke(
1257 Send node, 1258 Send node,
1258 ConstantExpression constant, 1259 ConstantExpression constant,
1259 NodeList arguments, 1260 NodeList arguments,
1260 CallStructure callStructure, 1261 CallStructure callStructure,
1261 _) { 1262 _) {
1262 return buildUnsupported(node, "ConstantInvoke"); 1263 // TODO(ahe): This method is never called. Is it a bug in semantic visitor?
1264 return internalError(node, "ConstantInvoke");
1263 } 1265 }
1264 1266
1265 @override 1267 @override
1266 ir.InvalidExpression visitConstructorIncompatibleInvoke( 1268 ir.InvalidExpression visitConstructorIncompatibleInvoke(
1267 NewExpression node, 1269 NewExpression node,
1268 ConstructorElement constructor, 1270 ConstructorElement constructor,
1269 InterfaceType type, 1271 InterfaceType type,
1270 NodeList arguments, 1272 NodeList arguments,
1271 CallStructure callStructure, 1273 CallStructure callStructure,
1272 _) { 1274 _) {
(...skipping 1780 matching lines...) Expand 10 before | Expand all | Expand 10 after
3053 : this(null, true, node, initializers); 3055 : this(null, true, node, initializers);
3054 3056
3055 accept(ir.Visitor v) => throw "unsupported"; 3057 accept(ir.Visitor v) => throw "unsupported";
3056 3058
3057 visitChildren(ir.Visitor v) => throw "unsupported"; 3059 visitChildren(ir.Visitor v) => throw "unsupported";
3058 3060
3059 String toString() { 3061 String toString() {
3060 return "IrFunction($kind, $isConstructor, $node, $initializers)"; 3062 return "IrFunction($kind, $isConstructor, $node, $initializers)";
3061 } 3063 }
3062 } 3064 }
OLDNEW
« no previous file with comments | « no previous file | test/kernel/regression/constant_get_and_invoke.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698