Issue 2085353008: Allow disabling of resampling in decodeAudioData

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2085353008: Allow disabling of resampling in decodeAudioData

Created:
4 years, 6 months ago by Raymond Toy

Modified:
4 years, 5 months ago

Reviewers:

CC:
chromium-reviews, blink-reviews, haraken, hongchan, Raymond Toy

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Allow disabling of resampling in decodeAudioData Add additional dictionary parameter to decodeAudioData to allow disabling the resampling of the decoded data. Currently, the decoded data is always resampled to the context sample rate. This allow this resampling to be disabled. BUG=622871 TEST=decode-audio-data-no-resampling.html

Patch Set 1 #

Patch Set 2 : Small API change, update tests #

Patch Set 3 : Rebase #

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+213 lines, -15 lines)			Patch
A	third_party/WebKit/LayoutTests/webaudio/decode-audio-data-no-resampling.html	View	1	1 chunk	+128 lines, -0 lines	0 comments	Download
A	third_party/WebKit/LayoutTests/webaudio/decode-audio-data-no-resampling-expected.txt	View	1	1 chunk	+13 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/modules/modules.gypi	View	1 2	2 chunks	+3 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/modules/webaudio/AsyncAudioDecoder.h	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	third_party/WebKit/Source/modules/webaudio/AsyncAudioDecoder.cpp	View	1 2	1 chunk	+13 lines, -4 lines	0 comments	Download
M	third_party/WebKit/Source/modules/webaudio/AudioContext.idl	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/WebKit/Source/modules/webaudio/BaseAudioContext.h	View	1 2	3 chunks	+10 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp	View	1 2	3 chunks	+39 lines, -2 lines	0 comments	Download
A +	third_party/WebKit/Source/modules/webaudio/DecodeAudioDataOptions.idl	View	1	1 chunk	+2 lines, -5 lines	0 comments	Download
M	third_party/WebKit/Source/platform/audio/AudioBus.cpp	View		1 chunk	+2 lines, -1 line	0 comments	Download