Issue 2085005: Removed the "Reload" button from the HTTP cache tab of the net-internals page...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2085005: Removed the "Reload" button from the HTTP cache tab of the net-internals page... (Closed)

Created:
10 years, 7 months ago by eroman

Modified:
9 years, 6 months ago

Reviewers:
Mike Belshe, cbentzel

CC:
chromium-reviews, arv (Not doing code reviews), ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Removed the "Reload" button from the HTTP cache tab of the net-internals page. The "Reload" button was used to refresh the stats + cache listings. With this change, I poll the statistics for updates, so the reload button is unecessary. Note that the cache listing is too expensive to poll, so I replaced it with a link to a listings page. Lastly, updated the text dump to include the http cache statistics. BUG=37421 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=47499

Patch Set 1 #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -47 lines)			Patch
M	chrome/browser/dom_ui/net_internals_ui.cc	View	3 chunks	+1 line, -11 lines	0 comments	Download
M	chrome/browser/resources/net_internals/dataview.js	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/net_internals/httpcacheview.js	View	3 chunks	+2 lines, -24 lines	0 comments	Download
M	chrome/browser/resources/net_internals/index.html	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	chrome/browser/resources/net_internals/main.js	View	5 chunks	+6 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

eroman

10 years, 7 months ago (2010-05-18 06:38:58 UTC) #4

Committed per Chris's LGTM.

Mike: If you have any comments I can address them in a follow-up CL.

Expand Messages | Collapse Messages