Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Unified Diff: chrome/browser/dom_ui/net_internals_ui.cc

Issue 2085005: Removed the "Reload" button from the HTTP cache tab of the net-internals page... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 10 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/net_internals/dataview.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/dom_ui/net_internals_ui.cc
===================================================================
--- chrome/browser/dom_ui/net_internals_ui.cc (revision 47239)
+++ chrome/browser/dom_ui/net_internals_ui.cc (working copy)
@@ -556,6 +556,7 @@
OnGetProxySettings(NULL);
OnGetBadProxies(NULL);
OnGetHostResolverCache(NULL);
+ OnGetHttpCacheInfo(NULL);
}
void NetInternalsMessageHandler::IOThreadImpl::OnGetProxySettings(
@@ -731,22 +732,12 @@
void NetInternalsMessageHandler::IOThreadImpl::OnGetHttpCacheInfo(
const Value* value) {
DictionaryValue* info_dict = new DictionaryValue();
- ListValue* entry_keys = new ListValue();
DictionaryValue* stats_dict = new DictionaryValue();
disk_cache::Backend* disk_cache = GetDiskCacheBackend(
context_getter_->GetURLRequestContext());
if (disk_cache) {
- // Iterate over all the entries in the cache, to discover the keys.
- // WARNING: this can be slow! (and will block the IO thread).
- void* iter = NULL;
- disk_cache::Entry* entry;
- while (disk_cache->OpenNextEntry(&iter, &entry)) {
- entry_keys->Append(Value::CreateStringValue(entry->GetKey()));
- entry->Close();
- }
-
// Extract the statistics key/value pairs from the backend.
std::vector<std::pair<std::string, std::string> > stats;
disk_cache->GetStats(&stats);
@@ -756,7 +747,6 @@
}
}
- info_dict->Set(L"keys", entry_keys);
info_dict->Set(L"stats", stats_dict);
CallJavascriptFunction(L"g_browser.receivedHttpCacheInfo", info_dict);
« no previous file with comments | « no previous file | chrome/browser/resources/net_internals/dataview.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698