Chromium Code Reviews
Help | Chromium Project | Sign in
(30)

Issue 2085005: Removed the "Reload" button from the HTTP cache tab of the net-internals page... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 11 months ago by eroman
Modified:
2 years, 10 months ago
CC:
chromium-reviews_chromium.org, arv, ben+cc_chromium.org
Visibility:
Public.

Description

Removed the "Reload" button from the HTTP cache tab of the net-internals page.

The "Reload" button was used to refresh the stats + cache listings.
With this change, I poll the statistics for updates, so the reload button is unecessary.

Note that the cache listing is too expensive to poll, so I replaced it with a link to a listings page.

Lastly, updated the text dump to include the http cache statistics.

BUG=37421
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=47499

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -47 lines) Lint Patch
M chrome/browser/dom_ui/net_internals_ui.cc View 3 chunks +1 line, -11 lines 0 comments 0 errors Download
M chrome/browser/resources/net_internals/dataview.js View 1 chunk +10 lines, -0 lines 0 comments 0 errors Download
M chrome/browser/resources/net_internals/httpcacheview.js View 3 chunks +2 lines, -24 lines 0 comments 0 errors Download
M chrome/browser/resources/net_internals/index.html View 1 chunk +3 lines, -4 lines 0 comments 0 errors Download
M chrome/browser/resources/net_internals/main.js View 5 chunks +6 lines, -8 lines 0 comments 0 errors Download
Commit:

Messages

Total messages: 4
eroman
3 years, 11 months ago #1
eroman
ping
3 years, 11 months ago #2
cbentzel (out until April 27)
Driveby LGTM
3 years, 11 months ago #3
eroman
3 years, 11 months ago #4
Committed per Chris's LGTM.

Mike: If you have any comments I can address them in a follow-up CL.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6